Theme: refactor colors and some fixes/updates #11640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastiaan van Stijn <[email protected]>
While more verbose, HSL colors (Hue, Saturation, Lightness) allow for easier selecting color variations that only differ in lightness, but have the same hue. This conversion also reveals some slight differences in hue between existing color-variations that I'll address in a follow-up commit. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Changes should be mostly invisible, except for a very slight increase in contrast in the "night" theme between the body-background and left/right navigation blocks. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
|
Deploy preview for docsdocker ready! Built with commit d405b17 |
|
@usha-mandya ptal; as mentioned above, changes should be mostly invisible with a (minor) change in contrast in the dark theme; let me know if that's a concern 😅 |
usha-mandya
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Reviewed the updates with @thaJeztah. The color changes are very subtle and doesn't impact the user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to "upstream" changes I have in my working branches 😅
While more verbose, HSL colors (Hue, Saturation, Lightness) allow for easier selecting color variations that only differ in lightness, but have the same hue. This conversion also reveals some slight differences in hue between existing color-variations that I'll address in a follow-up commit.
Changes should be mostly invisible, except for a very slight increase in contrast in the "night" theme between the body- background and left/right navigation blocks.