Support for docker.types.Placement.MaxReplicas #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocker Swarm Service Signed-off-by: WojciechowskiPiotr <[email protected]>
WojciechowskiPiotr
requested review from
aiordache and
ulyssessouza
as code owners
aiordache
approved these changes
Feb 9, 2021
aiordache
reviewed
Feb 9, 2021
docker/types/services.py
Outdated
| platforms (:py:class:`list` of tuple): A list of platforms | ||
| expressed as ``(arch, os)`` tuples | ||
| """ | ||
| def __init__(self, constraints=None, preferences=None, platforms=None): | ||
| def __init__(self, constraints=None, preferences=None, maxreplicas=None, |
There was a problem hiding this comment.
Can you add the new argument at the end please? This avoids breaking calls with positional args.
There was a problem hiding this comment.
Fixed as per your request, not sure why one of the tests failed this time
…ocker Swarm Service Signed-off-by: WojciechowskiPiotr <[email protected]>
|
Hello @WojciechowskiPiotr . Thank you for the contribution! Could you please add tests to your PR? |
Signed-off-by: WojciechowskiPiotr <[email protected]>
Hi @ulyssessouza, I've added integration and unit tests as per your request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Small PR adding support for Placement.MaxReplicas (new in API 1.40) in Docker Swarm Services. This was mentioned in #2528. There is also a feature request in ansible.docker community to support this feature (ansible-collections/community.docker#7).
Signed-off-by: WojciechowskiPiotr [email protected]