docker_swarm_service does not expose --replicas-max-per-node

[nicholasamorim]

SUMMARY

docker_swarm_service does not expose the --replicas-max-per-node that is very useful especially when running services that might need HA in a more strict manner (databases, etc)

ISSUE TYPE

• Feature Idea

COMPONENT NAME

docker_swarm_service

ADDITIONAL INFORMATION

[ansibullbot]

Files identified in the description:

• plugins/modules/cloud/docker/docker_swarm_service.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @DBendit @WojciechowskiPiotr @akshay196 @chouseknecht @danihodovic @dariko @felixfontein @hannseman @jwitko @kassiansun @tbouvet
click here for bot help

[WojciechowskiPiotr]

Hi @nicholasamorim,
I see this has been added in API 1.40. If nobody picks it, I will try to add it later this month.
Regards

[b2az]

just here to tell you, that i also need this in my playbooks.

[WojciechowskiPiotr]

just here to tell you, that i also need this in my playbooks.

Hi, the docker-py maintainers review my change proposal, so I how we can marge it soon. I have the patch for docker_swarm_service ready.

[WojciechowskiPiotr]

My change (docker/docker-py#2741) has been merged so as soon as the next version of docker-py is released I will implement this feature in docker_swarm_service

[WojciechowskiPiotr]

FYI my change in docker-py will be included in release 4.5.0 so we have to wait until it is released.

[hartwork]

FYI my change in docker-py will be included in release 4.5.0 so we have to wait until it is released.

While not mentioned in the change log of docker-py 4.4.3 I can confirm that docker/docker-py#2774 has just hit PyPI in release 4.4.3 already yesterday.

[felixfontein]

As long as they don't remove it again in 4.4.4, I guess we can start using it ;-)

[WojciechowskiPiotr]

Ok, I saw it on the list for the 4.5.0 release but it is even better it was included in 4.4.3 even by this small mistake :) In such case, I will prepare my change for community.docker shortly.

[felixfontein]

This has been implemented in #92 and will be available in the 1.3.0 release.