Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn user build.secrets uid,gid,mode are not implemented #10709

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jun 14, 2023

What I did
warn user that build.secrets uid,gid,mode are not implemented and will be ignored

Related issue
closes #10704

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.13 🎉

Comparison is base (586fe87) 58.79% compared to head (d20c255) 58.92%.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10709      +/-   ##
==========================================
+ Coverage   58.79%   58.92%   +0.13%     
==========================================
  Files         112      112              
  Lines        9743     9746       +3     
==========================================
+ Hits         5728     5743      +15     
+ Misses       3425     3416       -9     
+ Partials      590      587       -3     
Impacted Files Coverage Δ
pkg/compose/build.go 72.77% <0.00%> (-0.56%) ⬇️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ndeloof ndeloof requested review from a team, nicksieger, StefanScherer, ulyssessouza, glours, milas and laurazard and removed request for a team June 14, 2023 11:30
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit 2d4f8d3 into docker:v2 Jun 21, 2023
@ndeloof ndeloof deleted the secret_uid branch December 20, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Using long syntax for build secrets is not working properly
3 participants