Skip to content

Commit

Permalink
Merge pull request #10709 from ndeloof/secret_uid
Browse files Browse the repository at this point in the history
warn user build.secrets uid,gid,mode are not implemented
  • Loading branch information
glours authored Jun 21, 2023
2 parents e1f8603 + d20c255 commit 2d4f8d3
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/compose/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import (
"github.com/moby/buildkit/util/entitlements"
specs "github.com/opencontainers/image-spec/specs-go/v1"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"

"github.com/docker/compose/v2/pkg/api"
"github.com/docker/compose/v2/pkg/progress"
Expand Down Expand Up @@ -449,6 +450,9 @@ func addSecretsConfig(project *types.Project, service types.ServiceConfig) (sess
default:
return nil, fmt.Errorf("build.secrets only supports environment or file-based secrets: %q", secret.Source)
}
if secret.UID != "" || secret.GID != "" || secret.Mode != nil {
logrus.Warn("secrets `uid`, `gid` and `mode` are not supported by BuildKit, they will be ignored")
}
}
store, err := secretsprovider.NewStore(sources)
if err != nil {
Expand Down

0 comments on commit 2d4f8d3

Please sign in to comment.