run: fix GetList return empty issue for throttledevice #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size. This patch fix it by setting the related slice size to non-zero. Signed-off-by: Jianyong Wu <[email protected]> Fixes: docker#5321
jongwu
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5323 +/- ##
=======================================
Coverage 61.45% 61.45%
=======================================
Files 299 299
Lines 20855 20855
=======================================
Hits 12816 12816
Misses 7124 7124
Partials 915 915 |
thaJeztah
added
status/2-code-review
kind/bugfix
|
Doh! Nice catch. Looks like I introduced this in d0dee3c (d0dee3c#diff-5aaad03b8a6ef733357accbdeb0346dcad3b83c0a460b25c77ad83b726244a75R96) Ironically, that was to enable more linters, and the linters didn't complain on this one! 🙈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size.
- What I did
This patch fix it by setting the related slice size to non-zero.
- How to verify it
docker run --device-read-bps /dev/sda2:10M busybox sh -c 'dd if=/dev/zero of=/tmp.img bs=10M count=10 oflag=direct conv=fsync'- Description for the changelog