-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'--device-read-bps' '--device-write-bps' does not work #5321
Labels
Comments
thaJeztah
pushed a commit
to thaJeztah/cli
that referenced
this issue
Aug 9, 2024
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size. This patch fix it by setting the related slice size to non-zero. Signed-off-by: Jianyong Wu <[email protected]> Fixes: docker#5321 (cherry picked from commit 73e78a5) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
pushed a commit
to thaJeztah/cli
that referenced
this issue
Aug 9, 2024
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size. This patch fix it by setting the related slice size to non-zero. Signed-off-by: Jianyong Wu <[email protected]> Fixes: docker#5321 (cherry picked from commit 73e78a5) Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
pushed a commit
to thaJeztah/cli
that referenced
this issue
Aug 9, 2024
Test "--device-read-bps" "--device-write-bps" will fail. The root cause is that GetList helper return empty as its local variable initialized to zero size. This patch fix it by setting the related slice size to non-zero. Signed-off-by: Jianyong Wu <[email protected]> Fixes: docker#5321 (cherry picked from commit 73e78a5) Signed-off-by: Sebastiaan van Stijn <[email protected]>
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
using the latest docker/cli to test --device-write-bps does not work. It can't limit the IO bps.
Reproduce
docker run --device-read-bps /dev/sda2:10M busybox sh -c 'dd if=/dev/zero of=/tmp.img bs=10M count=10 oflag=direct conv=fsync'
Expected behavior
the speed of "dd" should be around 10M/s
docker version
docker info
Additional Info
No response
The text was updated successfully, but these errors were encountered: