Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure context store initialization for plugins #1716

Closed

Conversation

simonferquel
Copy link
Contributor

- What I did

Fixed a bug in cli-plugin initialization where the context store was not correctly initialized

Plugins have their cli initialized with a docker client pre-configured
(for dial-stdio). The problem here is that the cli initialization logic
skipped initializing the context store on this condition.

- How I did it

This PR adds a non-regression test for that alongside a fix (context
store and current context name are now resolved unconditionally)

- How to verify it

Run the unit tests

cc @ijc

Plugins have their cli initialized with a docker client pre-configured
(for dial-stdio). The problem here is that the cli initialization logic
skipped initializing the context store on this condition.

This commit adds a non-regression test for that alongside a fix (context
store and current context name are now resolved unconditionally)

Signed-off-by: Simon Ferquel <[email protected]>
@simonferquel
Copy link
Contributor Author

Closing in favor of #1690
@jcsirot can you port the unit test in your PR though ?

@simonferquel simonferquel deleted the plugins-context-store-init branch March 5, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants