Ensure context store initialization for plugins #1716
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fixed a bug in cli-plugin initialization where the context store was not correctly initialized
Plugins have their cli initialized with a docker client pre-configured
(for dial-stdio). The problem here is that the cli initialization logic
skipped initializing the context store on this condition.
- How I did it
This PR adds a non-regression test for that alongside a fix (context
store and current context name are now resolved unconditionally)
- How to verify it
Run the unit tests
cc @ijc