Always initialize context store #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
reviewed
Feb 25, 2019
Codecov Report
@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
+ Coverage 56.13% 56.19% +0.05%
==========================================
Files 306 306
Lines 21038 21037 -1
==========================================
+ Hits 11809 11821 +12
+ Misses 8374 8357 -17
- Partials 855 859 +4 |
ulyssessouza
added a commit
to docker/app
that referenced
this pull request
Mar 7, 2019
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
chris-crone
pushed a commit
to chris-crone/app
that referenced
this pull request
Mar 7, 2019
- Update docker/cli is now pointing to ulyssessouza/cli. The change needs the merge of docker/cli#1710 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
chris-crone
pushed a commit
to chris-crone/app
that referenced
this pull request
Mar 8, 2019
- Update docker/cli is now pointing to chris-crone/cli. The change needs the merge of docker/cli#1718 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
chris-crone
pushed a commit
to chris-crone/app
that referenced
this pull request
Mar 8, 2019
- Update docker/cli is now pointing to chris-crone/cli. The change needs the merge of docker/cli#1718 and docker/cli#1690 - Fix issues relative paths in Jenkinsfile and Jenkinsfile.baguette - Avoid using '--config' in favor of env variable 'DOCKER_CONFIG' Signed-off-by: Ulysses Souza <[email protected]>
|
Please rebase this one :) |
jcsirot
force-pushed
the
fix-contextstore-for-plugins
branch
from
ee58656 to
ef04489
Compare
added 3 commits
March 13, 2019 14:18
Signed-off-by: Jean-Christophe Sirot <[email protected]>
…t case the `TestDialStdio` e2e test had to be modified: the `--tls` option triggers an error since the endpoint resolution tries to read the `${DOCKER_CERT_PATH}/ca.pem` file which does not exist.
Signed-off-by: Jean-Christophe Sirot <[email protected]>
Signed-off-by: Jean-Christophe Sirot <[email protected]>
jcsirot
force-pushed
the
fix-contextstore-for-plugins
branch
from
ef04489 to
a1af6e2
Compare
|
@thaJeztah PTAL |
thaJeztah
approved these changes
Mar 18, 2019
| @@ -209,12 +209,13 @@ func (cli *DockerCli) Initialize(opts *cliflags.ClientOptions, ops ...Initialize | |||
|
|
|||
| cli.configFile = cliconfig.LoadDefaultConfigFile(cli.err) | |||
|
|
|||
| cli.contextStore = store.New(cliconfig.ContextStoreDir(), cli.contextStoreConfig) | |||
There was a problem hiding this comment.
Not for this PR, but wondering if we should consider having a WithContextStore() ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Always initialize context store even when the CLI has already a client. It happens when the CLI is initialized from a plugin.
- A picture of a cute animal (not mandatory but encouraged)