Only set default rootless image if it is not already customized #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if you think there is a better way to solve this issue. This was the simplest thing I could think to do. |
dougborg
force-pushed
the
custom-rootless-image-fix
branch
from
fd56af5
to
35c62e3
Compare
AkihiroSuda
approved these changes
Apr 12, 2022
tonistiigi
reviewed
Apr 12, 2022
dougborg
force-pushed
the
custom-rootless-image-fix
branch
from
35c62e3
to
02901eb
Compare
Only change the image to the default rootless image when using the --rootless option if the image has not already customized with the --image option. Fix docker#938 Signed-off-by: Doug Borg <[email protected]>
dougborg
force-pushed
the
custom-rootless-image-fix
branch
from
02901eb
to
79de2c5
Compare
tonistiigi
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only change the image to the default rootless image when using the
--rootless option if the image has not already customized with the
--image option.
Fix #938
Signed-off-by: Douglas Borg [email protected]