-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubernetes driver ignores --driver-opt image when rootless opt is set #938
Comments
One more observation, removing |
Another observation, this used to work fine at least till docker client version 20.10.6. So, some change between 20.10.6 and 20.10.12 should be causing it. |
Yes, rootless overrides the image property with default image atm. https://github.com/docker/buildx/blob/master/driver/kubernetes/factory.go#L109 . It should not do that when custom image is set. Atm it looks like the behavior might even be random as maps in Go are not sorted. |
@tonistiigi how to check if the custom image is set or not |
Only change the image to the default rootless image when using the --rootless option if the image has not already customized with the --image option. Fix docker#938 Signed-off-by: Douglas Borg <[email protected]>
Only change the image to the default rootless image when using the --rootless option if the image has not already customized with the --image option. Fix docker#938 Signed-off-by: Doug Borg <[email protected]>
Only change the image to the default rootless image when using the --rootless option if the image has not already customized with the --image option. Fix docker#938 Signed-off-by: Doug Borg <[email protected]>
Only change the image to the default rootless image when using the --rootless option if the image has not already customized with the --image option. Fix docker#938 Signed-off-by: Doug Borg <[email protected]>
Respected members of the buildx team and community,
We are using buildx to generate multi-arch images in arm64/amd64 architectures using the kubernetes driver. We are pushing to a private registry and we have a custom base image with root certificates to access the private registry. The commands we use are:
But intermittently we see that the
--driver-opt image=demo/demo-buildkit:amd64
or--driver-opt image=demo/demo-buildkit:arm64
gets ignored and the kubernetes pod is created withmoby/buildkit
image:A weird observation is that sometimes of out of the two nodes, the option i.e.
--driver-opt image=demo/demo-buildkit:amd64
is ignored for just one node and the second node works fine. And some other times both work fine and images get built correctly.Because of this problem, our builds are extremely inconsistent and fail with the error below when
moby/buildkit
image is used:Our build environment details:
Any guidance or advice is highly appreciated! Thanks! 🙇
The text was updated successfully, but these errors were encountered: