Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sanity tests for examples #43

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Add sanity tests for examples #43

merged 1 commit into from
Apr 5, 2023

Conversation

jedevc
Copy link
Collaborator

@jedevc jedevc commented Apr 5, 2023

🛠️ Fixes #26

Introduces a set of simple schema checks for the resulting SPDX files.

@jedevc jedevc requested review from cdupuis and crazy-max April 5, 2023 14:51
@jedevc jedevc force-pushed the e2e-tests branch 3 times, most recently from 97c06f4 to d6f33b9 Compare April 5, 2023 15:02
crazy-max
crazy-max approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

cdupuis
cdupuis approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @jedevc. This will make future updates so much easier.

@jedevc jedevc merged commit 2837cf2 into docker:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

@cdupuis cdupuis cdupuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End-to-end tests
3 participants
@jedevc @cdupuis @crazy-max