Explicitly enable phpdbg in CLI images and *disable* it in all others #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
commented
Mar 2, 2022
| {{ if env.variant == "cli" then ( -}} | ||
| # https://github.com/docker-library/php/pull/1259 | ||
| --enable-phpdbg \ | ||
| --enable-phpdbg-readline \ |
There was a problem hiding this comment.
I'm not sure how difficult it would be to make the default of this mirror whether we did --with-readline but that's certainly above my pay grade! 😄
yosifkit
approved these changes
Mar 2, 2022
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 2, 2022
Changes: - docker-library/php@3fb78b3: Merge pull request docker-library/php#1259 from infosiftr/phpdbg - docker-library/php@c1d6083: Explicitly enable phpdbg in CLI images and *disable* it in all others - docker-library/php@5a45417: Fix generate-stackbrew-library.sh to skip released RCs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1257
See also bwoebi/phpdbg-docs#1 (comment) (which is a comment from a PHP release manager ❤️):
This should save ~13MB on all non-CLI variants (and no increase for CLI because it already included it 😂 😇).