Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable readline in phpdbg #1257

Closed
computator opened this issue Feb 28, 2022 · 4 comments · Fixed by #1259
Closed

Enable readline in phpdbg #1257

computator opened this issue Feb 28, 2022 · 4 comments · Fixed by #1259
Labels
Request Request for image modification or feature

Comments

@computator
Copy link

phpdbg and readline are already both enabled by default, however the --enable-phpdbg-readline flag is not set to enable readline in phpdbg. If this could be enabled it would make using phpdbg much more convenient!
@wglambert wglambert added the Request Request for image modification or feature label Feb 28, 2022
@tianon
Copy link
Member

tianon commented Mar 1, 2022

If phpdbg is enabled, it's definitely not on purpose. 😬 🙈

@computator
Copy link
Author

Well it's definitely useful, so don't disable it or anything, or at the least leave it enabled in the CLI variants please :)

@tianon tianon mentioned this issue Mar 2, 2022
Merged
@tianon
Copy link
Member

tianon commented Mar 2, 2022

Apparently we were excited to have it implicitly (looking through old issue comments), so I've codified the explicit stance (and included readline) in #1259. 👍

@computator
Copy link
Author

Awesome, thanks!

@MinDBreaK MinDBreaK mentioned this issue Mar 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Request Request for image modification or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly enable phpdbg in CLI images and *disable* it in all others infosiftr/php
3 participants
@tianon @computator @wglambert