Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Handle a Docker daemon without registry info #10

Merged
merged 1 commit into from
Jun 5, 2017

Commits on May 31, 2017

  1. Handle a Docker daemon without registry info

    The current implementation of the ElectAuthServer doesn't handle well when the
    default Registry server is not included in the response from the daemon Info
    endpoint.
    
    That leads to the storage and usage of the credentials for the default registry
    (`https://index.docker.io/v1/`) under an empty string on the client config file.
    
    Sample config file after a login via a Docker Daemon without Registry
    information:
    ```json
    {
    	"auths": {
    		"": {
    			"auth": "***"
    		}
    	}
    }
    ```
    
    That can lead to duplication of the password for the default registry and
    authentication failures against the default registry if a pull/push is performed
    without first authenticating via the misbehaving daemon.
    
    Also, changes the output of the warning message from stdout to sdterr as
    per dnephin suggestion.
    
    Signed-off-by: Marcus Martins <[email protected]>
    (cherry picked from commit 862649707ef2b901fc0535895de7456fc4c9c0c3)
    marcusmartins authored and mlaventure committed May 31, 2017
    Configuration menu
    Copy the full SHA
    32807d0 View commit details
    Browse the repository at this point in the history