This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Handle a Docker daemon without registry info #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the ElectAuthServer doesn't handle well when the default Registry server is not included in the response from the daemon Info endpoint. That leads to the storage and usage of the credentials for the default registry (`https://index.docker.io/v1/`) under an empty string on the client config file. Sample config file after a login via a Docker Daemon without Registry information: ```json { "auths": { "": { "auth": "***" } } } ``` That can lead to duplication of the password for the default registry and authentication failures against the default registry if a pull/push is performed without first authenticating via the misbehaving daemon. Also, changes the output of the warning message from stdout to sdterr as per dnephin suggestion. Signed-off-by: Marcus Martins <[email protected]> (cherry picked from commit 862649707ef2b901fc0535895de7456fc4c9c0c3)
23 tasks
|
@mlaventure do you need LGTM here? |
|
LGTM integration and unit tests are green |
|
@marcusmartins they're always appreciated ;-) PR is here so the integration-test can run on it, unless the tests fail or there's a conflict, I don't think we'll require formal LGTMs. However, an extra pair of eyes is always useful. |
|
post merge LGTM. thanks @mlaventure |
andrewhsu
added a commit
that referenced
this pull request
Jul 14, 2017
Add reflective alpine images to other components Upstream-commit: f373edf Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Jul 5, 2018
[18.06] vendor: update buildkit to 9acf51e491 Upstream-commit: c9bfc3c842d847dfeee105756e456be148b9d461 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
…e_images Add reflective alpine images to other components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the ElectAuthServer doesn't handle well when the
default Registry server is not included in the response from the daemon Info
endpoint.
That leads to the storage and usage of the credentials for the default registry
(
https://index.docker.io/v1/) under an empty string on the client config file.Sample config file after a login via a Docker Daemon without Registry
information:
{ "auths": { "": { "auth": "***" } } }That can lead to duplication of the password for the default registry and
authentication failures against the default registry if a pull/push is performed
without first authenticating via the misbehaving daemon.
Also, changes the output of the warning message from stdout to sdterr as
per dnephin suggestion.
Signed-off-by: Marcus Martins [email protected]
(cherry picked from commit 862649707ef2b901fc0535895de7456fc4c9c0c3)
Cherry pick of docker/cli#126