Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Pin ECS secrets sidecar image & add makefile targets #876

Merged
merged 1 commit into from
Nov 4, 2020

Conversation

gtardif
Copy link
Contributor

@gtardif gtardif commented Nov 4, 2020

Signed-off-by: Guillaume Tardif [email protected]

What I did

  • pin docker/ecs-secrets-sidecar:1.0 in ecs/convert.go
  • check ECS E2E test fail, image not found
  • add target to ublish image in makefile, and publish tag 1.0

Related issue

/test-ecs

(not mandatory) A picture of a cute animal, if possible in relation with what you did

@gtardif gtardif requested a review from ndeloof November 4, 2020 09:39
@github-actions github-actions bot added the ecs label Nov 4, 2020
Copy link
Collaborator

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your implementation of the "immutable tag" feature :P

@gtardif gtardif merged commit 4b88896 into main Nov 4, 2020
@gtardif gtardif deleted the ecs_pin_secret_sidecar branch November 4, 2020 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants