Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Commit

Permalink
Merge pull request #876 from docker/ecs_pin_secret_sidecar
Browse files Browse the repository at this point in the history
Pin ECS secrets sidecar image & add makefile targets
  • Loading branch information
gtardif authored Nov 4, 2020
2 parents 4fc73d1 + 8cc438c commit 4b88896
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ build-ecs-search-sidecar: ## build ecs search sidecar image locally and tag it
publish-ecs-search-sidecar: build-ecs-search-sidecar ## build & publish ecs search sidecar image with make publish-ecs-search-sidecar tag=0.1
docker pull docker/ecs-searchdomain-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/ecs-searchdomain-sidecar:$(tag)

build-ecs-secrets-sidecar: ## build ecs secrets sidecar image locally and tag it with make build-ecs-secrets-sidecar tag=0.1
docker build -t docker/ecs-secrets-sidecar:$(tag) ecs/secrets

publish-ecs-secrets-sidecar: build-ecs-secrets-sidecar ## build & publish ecs secrets sidecar image with make publish-ecs-secrets-sidecar tag=0.1
docker pull docker/ecs-secrets-sidecar:$(tag) && echo "Failure: Tag already exists" || docker push docker/ecs-secrets-sidecar:$(tag)

clean-aci-e2e: ## Make sure no ACI tests are currently runnnig in the CI when invoking this. Delete ACI E2E tests resources that might have leaked when ctrl-C E2E tests.
@ echo "Will delete resource groups: "
@ az group list | jq '.[].name' | grep -i E2E-Test
Expand Down
2 changes: 1 addition & 1 deletion ecs/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import (
"github.com/joho/godotenv"
)

const secretsInitContainerImage = "docker/ecs-secrets-sidecar"
const secretsInitContainerImage = "docker/ecs-secrets-sidecar:1.0"
const searchDomainInitContainerImage = "docker/ecs-searchdomain-sidecar:1.0"

func (b *ecsAPIService) createTaskDefinition(project *types.Project, service types.ServiceConfig, resources awsResources) (*ecs.TaskDefinition, error) {
Expand Down

0 comments on commit 4b88896

Please sign in to comment.