This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 255
introduce compose rm command #1299
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
/* | ||
Copyright 2020 Docker Compose CLI authors | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package compose | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/docker/compose-cli/api/client" | ||
"github.com/docker/compose-cli/api/compose" | ||
"github.com/docker/compose-cli/api/progress" | ||
"github.com/docker/compose-cli/utils/prompt" | ||
|
||
"github.com/spf13/cobra" | ||
) | ||
|
||
type removeOptions struct { | ||
*projectOptions | ||
force bool | ||
stop bool | ||
volumes bool | ||
} | ||
|
||
func removeCommand(p *projectOptions) *cobra.Command { | ||
opts := removeOptions{ | ||
projectOptions: p, | ||
} | ||
cmd := &cobra.Command{ | ||
Use: "rm [SERVICE...]", | ||
Short: "Removes stopped service containers", | ||
Long: `Removes stopped service containers | ||
By default, anonymous volumes attached to containers will not be removed. You | ||
can override this with -v. To list all volumes, use "docker volume ls". | ||
Any data which is not in a volume will be lost.`, | ||
RunE: func(cmd *cobra.Command, args []string) error { | ||
return runRemove(cmd.Context(), opts, args) | ||
}, | ||
} | ||
f := cmd.Flags() | ||
f.BoolVarP(&opts.force, "force", "f", false, "Don't ask to confirm removal") | ||
f.BoolVarP(&opts.stop, "stop", "s", false, "Stop the containers, if required, before removing") | ||
f.BoolVarP(&opts.volumes, "volumes", "v", false, "Remove any anonymous volumes attached to containers") | ||
return cmd | ||
} | ||
|
||
func runRemove(ctx context.Context, opts removeOptions, services []string) error { | ||
c, err := client.NewWithDefaultLocalBackend(ctx) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
project, err := opts.toProject(services) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if opts.stop { | ||
_, err = progress.Run(ctx, func(ctx context.Context) (string, error) { | ||
err := c.ComposeService().Stop(ctx, project) | ||
return "", err | ||
}) | ||
if err != nil { | ||
return err | ||
} | ||
} | ||
|
||
reosurces, err := c.ComposeService().Remove(ctx, project, compose.RemoveOptions{ | ||
DryRun: true, | ||
}) | ||
if err != nil { | ||
return err | ||
} | ||
|
||
if len(reosurces) == 0 { | ||
fmt.Println("No stopped containers") | ||
return nil | ||
} | ||
msg := fmt.Sprintf("Going to remove %s", strings.Join(reosurces, ", ")) | ||
if opts.force { | ||
fmt.Println(msg) | ||
} else { | ||
confirm, err := prompt.User{}.Confirm(msg, false) | ||
if err != nil { | ||
return err | ||
} | ||
if !confirm { | ||
return nil | ||
} | ||
} | ||
|
||
_, err = progress.Run(ctx, func(ctx context.Context) (string, error) { | ||
_, err = c.ComposeService().Remove(ctx, project, compose.RemoveOptions{ | ||
Volumes: opts.volumes, | ||
Force: opts.force, | ||
}) | ||
return "", err | ||
}) | ||
return err | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
/* | ||
Copyright 2020 Docker Compose CLI authors | ||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
http://www.apache.org/licenses/LICENSE-2.0 | ||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
|
||
package compose | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/docker/compose-cli/api/compose" | ||
"github.com/docker/compose-cli/api/progress" | ||
status "github.com/docker/compose-cli/local/moby" | ||
|
||
"github.com/compose-spec/compose-go/types" | ||
moby "github.com/docker/docker/api/types" | ||
"golang.org/x/sync/errgroup" | ||
) | ||
|
||
func (s *composeService) Remove(ctx context.Context, project *types.Project, options compose.RemoveOptions) ([]string, error) { | ||
containers, err := s.getContainers(ctx, project, oneOffInclude) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
stoppedContainers := containers.filter(func(c moby.Container) bool { | ||
return c.State != status.ContainerRunning | ||
}) | ||
|
||
var names []string | ||
stoppedContainers.forEach(func(c moby.Container) { | ||
names = append(names, getCanonicalContainerName(c)) | ||
}) | ||
|
||
if options.DryRun { | ||
return names, nil | ||
} | ||
|
||
w := progress.ContextWriter(ctx) | ||
eg, ctx := errgroup.WithContext(ctx) | ||
for _, c := range stoppedContainers { | ||
c := c | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. required. go iteration re-assigning |
||
eg.Go(func() error { | ||
eventName := getContainerProgressName(c) | ||
w.Event(progress.RemovingEvent(eventName)) | ||
err = s.apiClient.ContainerRemove(ctx, c.ID, moby.ContainerRemoveOptions{ | ||
RemoveVolumes: options.Volumes, | ||
Force: options.Force, | ||
}) | ||
if err == nil { | ||
w.Event(progress.RemovedEvent(eventName)) | ||
} | ||
return err | ||
}) | ||
} | ||
return nil, eg.Wait() | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add
remove
as alias?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no such thing as a
remove
alias ondocker rm
nordocker-compose rm
, so to prevent heterogeneous UX I'd prefer we keep such "UX improvement" a separate debate