This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
introduce compose rm command #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
aci
api
Signed-off-by: Nicolas De Loof <[email protected]>
aiordache
reviewed
Feb 15, 2021
| projectOptions: p, | ||
| } | ||
| cmd := &cobra.Command{ | ||
| Use: "rm [SERVICE...]", |
There was a problem hiding this comment.
Could we add remove as alias?
There was a problem hiding this comment.
there's no such thing as a remove alias on docker rm nor docker-compose rm, so to prevent heterogeneous UX I'd prefer we keep such "UX improvement" a separate debate
aiordache
reviewed
Feb 15, 2021
local/compose/remove.go
Outdated
| } | ||
| msg := fmt.Sprintf("Going to remove %s", strings.Join(names, ", ")) | ||
| if options.Force { | ||
| fmt.Println(msg) |
There was a problem hiding this comment.
Not sure about it but this may be the cause for the inconsistent output with the progress writer:
$ ./bin/docker compose rm --stop --force
The new 'docker compose' command is currently experimental. To provide feedback or request new features please open issues at https://github.com/docker/compose-cli
[+] Running 0/1
[+] Running 1/1mpose-cli_web_1 Stopping 0.3s
⠿ Container compose-cli_web_1 Removed 0.4s
There was a problem hiding this comment.
oh yes indeed, need to get user interaction to take place before the progresswriter is started. But can't do this without breaking the backend API abstraction. Damned :'(
aiordache
reviewed
Feb 15, 2021
| w := progress.ContextWriter(ctx) | ||
| eg, ctx := errgroup.WithContext(ctx) | ||
| for _, c := range stoppedContainers { | ||
| c := c |
There was a problem hiding this comment.
required. go iteration re-assigning c variable. such a stupid idiom (ㆆ _ ㆆ)
Signed-off-by: Nicolas De Loof <[email protected]>
aiordache
approved these changes
Feb 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Reproduced
docker-compose rmcommand and flags/test-windows
(not mandatory) A picture of a cute animal, if possible in relation with what you did
