Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Remove Full-Text Search #446

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

reglim
Copy link
Contributor

@reglim reglim commented Mar 6, 2023

As it was too complex, I removed the index and full-text search from the API, and added simple searching through the loaded projects and versions to the UI.

fixes: #445

As it was too complex, I removed the index and full-text search from the
API, and added simple searching through the loaded projects and versions
to the UI.

fixes: #445
@reglim reglim force-pushed the improvement/445-remove-full-text-search branch from d5568b8 to 5546ec4 Compare March 6, 2023 10:43
@fliiiix
Copy link
Member

fliiiix commented Mar 6, 2023

maybe reverting commits instead of doing a new commit?

@reglim reglim requested a review from randombenj March 6, 2023 14:17
@reglim
Copy link
Contributor Author

reglim commented Mar 6, 2023

@fliiiix Not ideal, because I also created the UI in those commits and we still need it, but changed a bit, and I think one commit is cleaner than a lot of reverts.

Copy link
Member

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reglim reglim merged commit d5dfa22 into main Mar 7, 2023
@reglim reglim deleted the improvement/445-remove-full-text-search branch March 7, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Full-Text Search
3 participants