-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues/3455 lerna build #3456
Issues/3455 lerna build #3456
Conversation
Thanks for taking a look at this @mtrutledge! These changes make sense, but it looks like the CI build is still failing. If you need an extra set of eyes, I'm always happy to help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Taking a look to see why the CI build is failing. It almost looks like the export bundle is trying to compile the dnn-react-common that is already compiled instead of just packaging it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solves the issue mentioned. I tested this.
Fixes #3455
Summary
Made sure that lerna knew about the workspace packages configured for yarn. Had to move React Common to the top to make sure it was built first. Also added scripts to the main package.json for a cleaner interface instead of calling lerna directly from msbuild.