Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: When building locally any changes made to dnn-react-common are not reflected and the library is always pulled from nom. #3455

Closed
1 of 3 tasks
mtrutledge opened this issue Jan 8, 2020 · 0 comments · Fixed by #3456 or #3462

Comments

@mtrutledge
Copy link
Contributor

Description of bug

If you make any changes to a module in the dnn-react-common components those changes will never be reflected upon subsequent builds.

Steps to reproduce

List the precise steps to reproduce the bug:

  1. Go to Dnn.AdminExperience/Dnn.ReactCommon/src and update one of the components in some way. The easiest is to add a new icon or update an existing icon
  2. Do the build and launch the site.
  3. Navigate to the component with the changes and see they have not been put in place.
  4. See error

Current behavior

The dnn-react-common package is never hoisted to the node_modules folder so the changes are never reflected. Instead, it leaves the package that was retrieved from npm in place.

Expected behavior

The changes in dnn-react-common should have been reflected in the build

Affected version

  • 10.0.0 alpha build
  • 9.5.0 alpha build
  • 9.4.3 latest supported release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment