Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Iterate): display divider #4422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(Iterate): display divider #4422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e3135
quickfix
langz Dec 20, 2024
3fd9eab
screenshot test
langz Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified ..._/__image_snapshots__/iteratearray-have-to-match-filled-edit-container.snap.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 24 additions & 0 deletions packages/dnb-eufemia/src/extensions/forms/Iterate/stories/Iterate.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,3 +320,27 @@ export function InWizard() {
</React.StrictMode>
)
}

export const DisplayDividerWhenUsingContainer = () => (
<Form.Handler>
<Flex.Stack>
<Form.Card>
<Form.SubHeading>
Displaying divider line when using container
</Form.SubHeading>
<Iterate.Array path="/list" divider="line">
<Iterate.ViewContainer
variant="basic"
toolbarVariant="custom"
divider="line"
>
<Value.String label="Something" itemPath="/something" />
</Iterate.ViewContainer>
<Iterate.EditContainer variant="basic" divider="line">
<Field.String label="Something" itemPath="/something" />
</Iterate.EditContainer>
</Iterate.Array>
</Form.Card>
</Flex.Stack>
</Form.Handler>
)
5 changes: 0 additions & 5 deletions packages/dnb-eufemia/src/extensions/forms/Iterate/style/dnb-iterate.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,4 @@
&__element {
outline: none; // for JavaSCript focus
}

& > &__element:has(> .dnb-forms-section-block) {
// To make Animation not jump, we add "margin-bottom" in the inner element
margin-top: 0;
}
}
Loading