Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): correct 'data' type to support interface-based types #4383

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix(Dropdown): correct 'data' type to support interface-based types #4383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3d969f0
fix(Dropdown): fix using interface as type for data
langz Dec 11, 2024
8988fb6
Update packages/dnb-eufemia/src/components/dropdown/stories/Dropdown.…
langz Dec 11, 2024
0bc00ee
fix(Dropdown): fix using interface as type for data
langz Dec 11, 2024
1143f5d
fix(Dropdown): fix using interface as type for data
langz Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/dnb-eufemia/src/components/dropdown/stories/Dropdown.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1006,6 +1006,17 @@ export const GlobalStatusExample = () => {
)
}

export const TypesExample = () => {
interface MyInterface {
content: string
selected_key: string
}

const myData: MyInterface[] = []

return <Dropdown data={myData} />
}

export function InDialog() {
const list = Array(30).fill('Content')
return (
Expand Down
2 changes: 1 addition & 1 deletion packages/dnb-eufemia/src/fragments/drawer-list/DrawerList.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export type DrawerListValue = string | number;
/** @deprecated use `DrawerListDataArrayObject` */
export type DrawerListDataObject = DrawerListDataArrayObject;
export type DrawerListDataArrayObject = {
[customProperty: string]: unknown;
[customProperty: string]: any;
selected_value?: string | React.ReactNode;
selectedKey?: string | number;
selected_key?: string | number;
Expand Down
Loading