fix(Dropdown): correct 'data' type to support interface-based types #4383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
langz
commented
Dec 11, 2024
packages/dnb-eufemia/src/components/dropdown/stories/Dropdown.stories.tsx
Outdated
Show resolved
Hide resolved
langz
changed the title
langz
requested review from
snorrekim and
tujoworker
and removed request for
snorrekim
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
changed the title
langz
changed the title
langz
changed the title
data
tujoworker
approved these changes
Dec 11, 2024
tujoworker
changed the title
data
tujoworker
pushed a commit
that referenced
this pull request
Dec 11, 2024
## [10.60.1](v10.60.0...v10.60.1) (2024-12-11) ### 🐛 Bug Fixes * **Dropdown:** correct 'data' type to support interface-based types ([#4383](#4383)) ([461e258](461e258)) * **Forms:** ensure Tools.Log formats arrays with square brackets ([#4384](#4384)) ([7905694](7905694)) * **Upload:** add gap between file and remove button ([#4382](#4382)) ([04c1f6a](04c1f6a)) * **Upload:** avoid scrolling when removing file from list ([#4380](#4380)) ([43a64d4](43a64d4)) * **Upload:** handling of multiple async events ([#4378](#4378)) ([fd1fef9](fd1fef9))
|
🎉 This PR is included in version 10.60.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following error when using an
interfacefor thedataproperty:If I would use a
typeinstead of aninterfaceit will work.Here's a CSB using interface, here's a CSB using type.
But shouldn't I be able to use an
interface?Here's a CSB using interface and the fix from this PR