Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release of v10.60.1 #4381

Merged
merged 5 commits into from
Dec 11, 2024
Merged

release of v10.60.1 #4381

merged 5 commits into from
Dec 11, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 11, 2024

No description provided.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 11:03am

Copy link

codesandbox-ci bot commented Dec 11, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

langz and others added 2 commits December 11, 2024 11:45
…4383)

Fixes the following error when using an `interface` for the `data`
property:

```
No overload matches this call.
  Overload 1 of 2, '(props: DropdownAllProps | Readonly<DropdownAllProps>): Dropdown', gave the following error.
    Type 'MyInterface[]' is not assignable to type 'DrawerListData'.
      Type 'MyInterface[]' is not assignable to type 'DrawerListDataArray'.
        Type 'MyInterface' is not assignable to type 'DrawerListDataArrayItem'.
          Type 'MyInterface' is not assignable to type 'DrawerListDataArrayObject'.
            Index signature for type 'string' is missing in type 'MyInterface'.
  Overload 2 of 2, '(props: DropdownAllProps, context: any): Dropdown', gave the following error.
    Type 'MyInterface[]' is not assignable to type 'DrawerListData'.ts(2769)
```

If I would use a `type` instead of an `interface` it will work.
Here's a [CSB using
interface](https://codesandbox.io/p/sandbox/sleepy-fire-y58qqv), here's
a [CSB using
type](https://codesandbox.io/p/sandbox/stupefied-shtern-2kzvt4?workspaceId=ws_LbiDwJdEBdbwxH2AkyAyVE).
But shouldn't I be able to use an `interface`?

Here's a [CSB using interface and the fix from this
PR](https://codesandbox.io/p/sandbox/cranky-saha-728m3q?workspaceId=ws_LbiDwJdEBdbwxH2AkyAyVE)
@langz langz merged commit 76b5f39 into release Dec 11, 2024
5 of 8 checks passed
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.60.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants