Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Upload): adds onFileClick event #4365

Merged
merged 5 commits into from
Dec 6, 2024
Merged

feat(Upload): adds onFileClick event #4365

merged 5 commits into from
Dec 6, 2024

Conversation

langz
Copy link
Contributor

@langz langz commented Dec 6, 2024

I'll add support for a async onFileClick event in an upcoming PR, after this is merged #4351, as I'll reuse some functions from there.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 0:21am

Copy link

codesandbox-ci bot commented Dec 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of small adjustments.

@torryt
Copy link

torryt commented Dec 6, 2024

I really appreciate how quick you are to respond to requests and deliver features. That goes to everyone in the Eufemia team! Thank you 👏 👏 🎉 🎉

@langz langz force-pushed the feat/upload-on-file-click branch from 8d8a561 to 27a3911 Compare December 6, 2024 11:26
@langz
Copy link
Contributor Author

langz commented Dec 6, 2024

We probably need to add this functionality to Value.Upload as well?

Is that urgent @torryt?

@langz langz merged commit c5abd0e into main Dec 6, 2024
6 of 9 checks passed
@langz langz deleted the feat/upload-on-file-click branch December 6, 2024 12:15
@langz
Copy link
Contributor Author

langz commented Dec 6, 2024

We probably need to add this functionality to Value.Upload as well?

Is that urgent @torryt?

Will add it in this PR #4367

tujoworker pushed a commit that referenced this pull request Dec 10, 2024
## [10.60.0](v10.59.0...v10.60.0) (2024-12-10)

### 📝 Documentation

* **Upload:** adds `exists` to file object ([#4346](#4346)) ([52f8b2f](52f8b2f))
* **Upload:** adds exists to docs ([b6baa64](b6baa64))

### ✨ Features

* **Field.Upload:** add `onFileClick` event ([#4369](#4369)) ([c892eec](c892eec))
* **Forms:** add `Form.InfoOverlay` to display error, success (receipt), or custom messages to users ([#4357](#4357)) ([9dd8402](9dd8402))
* **Forms:** add `onAnimationEnd` property to Form.Visibility ([#4356](#4356)) ([87728b4](87728b4)), closes [#4350](#4350)
* **Forms:** add `onVisible` property to Form.Visibility ([#4350](#4350)) ([41306d8](41306d8))
* host fonts in the public directory ([#4359](#4359)) ([e6e08b2](e6e08b2))
* **Upload:** add support for async `onFileClick` event ([#4370](#4370)) ([82588c1](82588c1))
* **Upload:** adds `onFileClick` event ([#4365](#4365)) ([c5abd0e](c5abd0e))
* **Upload:** adds support for async `onFileDelete` ([#4351](#4351)) ([f41e42d](f41e42d))
* **Value.Upload:** add `onFileClick` event ([#4367](#4367)) ([56e9caf](56e9caf))

### 🐛 Bug Fixes

* **Dropdown:** enhance height calcilation and add support for strict `direction="bottom"` usage, including when used in a Dialog component ([#4368](#4368)) ([32b7b5b](32b7b5b))
* **Field.Upload:** handling of multiple async file uploads ([#4360](#4360)) ([5cb1518](5cb1518))
* **Forms:** avoid unnecessary rerenders in Form.Handler ([#4363](#4363)) ([7de5e49](7de5e49)), closes [#4357](#4357)
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.60.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@torryt
Copy link

torryt commented Dec 10, 2024

We probably need to add this functionality to Value.Upload as well?
Is that urgent @torryt?

Will add it in this PR #4367

Sorry for not responding @langz ! I get these notifications on my private email, so I don't always notice them. But thanks for fixing it anyways 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants