fix(Forms): avoid unnecessary rerenders in Form.Handler #4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
force-pushed
the
fix/forms-handler-rerender
branch
from
f1d023d to
0c43b76
Compare
tujoworker
pushed a commit
that referenced
this pull request
Dec 10, 2024
## [10.60.0](v10.59.0...v10.60.0) (2024-12-10) ### 📝 Documentation * **Upload:** adds `exists` to file object ([#4346](#4346)) ([52f8b2f](52f8b2f)) * **Upload:** adds exists to docs ([b6baa64](b6baa64)) ### ✨ Features * **Field.Upload:** add `onFileClick` event ([#4369](#4369)) ([c892eec](c892eec)) * **Forms:** add `Form.InfoOverlay` to display error, success (receipt), or custom messages to users ([#4357](#4357)) ([9dd8402](9dd8402)) * **Forms:** add `onAnimationEnd` property to Form.Visibility ([#4356](#4356)) ([87728b4](87728b4)), closes [#4350](#4350) * **Forms:** add `onVisible` property to Form.Visibility ([#4350](#4350)) ([41306d8](41306d8)) * host fonts in the public directory ([#4359](#4359)) ([e6e08b2](e6e08b2)) * **Upload:** add support for async `onFileClick` event ([#4370](#4370)) ([82588c1](82588c1)) * **Upload:** adds `onFileClick` event ([#4365](#4365)) ([c5abd0e](c5abd0e)) * **Upload:** adds support for async `onFileDelete` ([#4351](#4351)) ([f41e42d](f41e42d)) * **Value.Upload:** add `onFileClick` event ([#4367](#4367)) ([56e9caf](56e9caf)) ### 🐛 Bug Fixes * **Dropdown:** enhance height calcilation and add support for strict `direction="bottom"` usage, including when used in a Dialog component ([#4368](#4368)) ([32b7b5b](32b7b5b)) * **Field.Upload:** handling of multiple async file uploads ([#4360](#4360)) ([5cb1518](5cb1518)) * **Forms:** avoid unnecessary rerenders in Form.Handler ([#4363](#4363)) ([7de5e49](7de5e49)), closes [#4357](#4357)
|
🎉 This PR is included in version 10.60.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason behind this is that I saw a negative side-effect in PR #4357 when it comes to the initial render, where we don't want an animation, but it did animate.