Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Forms): ensure Form.Card supports spacing props #4328

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

tujoworker
Copy link
Member

Without, it will result in such wired cases like that:

iterate-edit-view-issue.mov

@tujoworker tujoworker requested a review from langz November 22, 2024 10:49
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 0:07am

@tujoworker tujoworker mentioned this pull request Nov 22, 2024
Copy link

codesandbox-ci bot commented Nov 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find🥳✅

@tujoworker tujoworker force-pushed the fix/card-space-support branch from 9d958d2 to 01555be Compare November 22, 2024 11:58
@tujoworker tujoworker merged commit f981b42 into main Nov 22, 2024
10 checks passed
@tujoworker tujoworker deleted the fix/card-space-support branch November 22, 2024 12:52
tujoworker pushed a commit that referenced this pull request Nov 22, 2024
## [10.57.1](v10.57.0...v10.57.1) (2024-11-22)

### 🔁 CI

* only run GitHub Actions on git commits ([#4327](#4327)) ([8a07477](8a07477))

### 🐛 Bug Fixes

* **CountryFlag:** include flag icons in repo instead of via dependency ([#4324](#4324)) ([69dc60a](69dc60a)), closes [#4307](#4307)
* **Forms:** ensure Form.Card supports spacing props ([#4328](#4328)) ([f981b42](f981b42))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.57.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants