fix(CountryFlag): include flag icons in repo instead of via dependency #4324
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
langz
changed the title
There was a problem hiding this comment.
Looks good 🇳🇴
Is it just straight-forward to copy all the flags from the dependency/package flag-icons? Or do we have to consider some kind of license?
Now we'll have to maintain the flags ourselves though, but I'm not sure how often flags change 🤔
Maybe we'll just have to listen/subscribe for changes in flag-icons package, then change in our codebase if we find any changes there? 🤔
Yes – but true, we should add a license file where the SVG's are placed.
Yes. |
Motivation for the bugfix release is mainly this fix #4324
## [10.57.1](v10.57.0...v10.57.1) (2024-11-22) ### 🔁 CI * only run GitHub Actions on git commits ([#4327](#4327)) ([8a07477](8a07477)) ### 🐛 Bug Fixes * **CountryFlag:** include flag icons in repo instead of via dependency ([#4324](#4324)) ([69dc60a](69dc60a)), closes [#4307](#4307) * **Forms:** ensure Form.Card supports spacing props ([#4328](#4328)) ([f981b42](f981b42))
|
🎉 This PR is included in version 10.57.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
There are a couple of projects which has had issues with the flag-icons package.
Where their bundler did change the path from 'flag-icons/flags/1x1/xx.svg' to './flag-icons/flags/1x1/xx.svg'
so it did add a './' in front of the path, which is not a valid path.
Therefore we include these SVGs in our assets folder, and point to them with a valid path.