Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Forms): add onDone, onCancel and onEdit to Form.Section containers #4199

Merged
merged 1 commit into from
Oct 30, 2024
Merged

feat(Forms): add onDone, onCancel and onEdit to Form.Section containers #4199

merged 1 commit into from
Oct 30, 2024

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Oct 30, 2024 •
edited
Loading

This allows to listen on the Toolbar button events:

<Form.Section>
  <Form.Section.EditContainer onDone={onDone} onCancel={onCancel}>
    <Field.Name required path="/name" />
  </Form.Section.EditContainer>

  <Form.Section.ViewContainer onEdit={onEdit}>
    <Value.Name path="/name" />
  </Form.Section.ViewContainer>
</Form.Section>

@vercel Vercel
Copy link

vercel bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 2:52pm

@tujoworker tujoworker requested a review from langz October 30, 2024 14:31
@tujoworker tujoworker force-pushed the feat/section-container-events branch from 6c2c024 to 26d4bba Compare October 30, 2024 14:32
langz
langz approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@langz langz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast ⚡
I just finished reading the Slack post 😀

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@langz
Copy link
Contributor

langz commented Oct 30, 2024 •
edited
Loading

Should we add these properties to an own events tab in our docs? As of right now, these new events is listed under the properties tab.
But usually I would expect us to list them in the events tab(which do not exist for Edit and ViewContainer for now).

@tujoworker

@langz langz mentioned this pull request Oct 30, 2024
Merged
@tujoworker
Copy link
Member Author

We should avoid the Events tab in Eufemia forms. We may even move all events to the Properties table at some point. But I agree that we can add these in a separate table. What do you think?

@langz
Copy link
Contributor

langz commented Oct 30, 2024

We should avoid the Events tab in Eufemia forms. We may even move all events to the Properties table at some point. But I agree that we can add these in a separate table. What do you think?

Aha, ok so we should avoid it in Eufemia forms.
Fine by me.
But based on the «standard approach» used in our regular/base components, one would expect a events tab.

We can disucuss this some other time✅💚

@langz langz merged commit 2f27ad0 into main Oct 30, 2024
10 checks passed
@langz langz deleted the feat/section-container-events branch October 30, 2024 14:55
tujoworker added a commit that referenced this pull request Oct 30, 2024
@tujoworker
chore(Docs): move event properties to it's own event section
be9953e 
Fixes PR #4199
@tujoworker tujoworker mentioned this pull request Oct 30, 2024
Merged
tujoworker pushed a commit that referenced this pull request Oct 30, 2024
@semantic-release-bot
chore(release): 10.54.0 [skip ci]
e0f3ba2 
## [10.54.0](v10.53.0...v10.54.0) (2024-10-30)

### 📝 Documentation

* add documentation about `emptyValue` ([#4174](#4174)) ([52457ba](52457ba)), closes [#4070](#4070)

### 🐛 Bug Fixes

* **Field.Number:** `decimalLimit={0}` when `currency` should work ([#4167](#4167)) ([68123ea](68123ea))
* **Forms:** correct alignment of Wizard status message (error, warning, info) ([#4185](#4185)) ([a307cda](a307cda))
* **Forms:** ensure autocomplete="off" when autoComplete on Form.Handler is false ([#4184](#4184)) ([6795b9f](6795b9f))
* **Forms:** ensure correct sorting in Field.SelectCountry ([#4196](#4196)) ([8db7720](8db7720)), closes [#4195](#4195)
* **Forms:** fix schema validation for required paths with matching name ([#4189](#4189)) ([04caf61](04caf61)), closes [#4179](#4179)
* **Forms:** only run onBlurValidator when no other errors are present ([#4172](#4172)) ([d2797f1](d2797f1)), closes [#4074](#4074)
* **Forms:** render multiple (combined) Ajv errors with translated messages ([#4176](#4176)) ([2b62ef7](2b62ef7)), closes [#4052](#4052)
* **Forms:** updates country names in SelectCountry ([#4187](#4187)) ([bb1b67c](bb1b67c))
* **NumberFormat:** should not throw exception when providing an invalid currency ([#4192](#4192)) ([a0700cd](a0700cd))
* **Table:** fix visible hidden rows for additional expandable table rows ([#4188](#4188)) ([16b6101](16b6101))

### ✨ Features

* add CountryFlag component ([#4181](#4181)) ([76a0c47](76a0c47))
* **Dialog:** add `verticalAlignment` property with `top` alignment support ([#4190](#4190)) ([3ace8b0](3ace8b0))
* **Forms:** add `onDone`, `onCancel` and `onEdit` to Form.Section containers ([#4199](#4199)) ([2f27ad0](2f27ad0))
* **Forms:** add `transformData` to the onSubmit event of Form.Handler ([#4183](#4183)) ([748b604](748b604))
* **Forms:** deprecate `useErrorMessage` hook for when creating your own fields ([#4177](#4177)) ([2ae86f2](2ae86f2)), closes [#4162](#4162)
* **Forms:** deprecate Ajv `validationRule` in FormError and deprecate `errorMessages` keys like `pattern` in favor of Eufemia translation keys like `Field.errorPattern` ([#4162](#4162)) ([b50387a](b50387a))
* **Keyboard navigation:** add support for `key` property (useful for fire events like {ArrowDown} during tests) ([#4182](#4182)) ([cc1ffa8](cc1ffa8))
* **Upload:** `text` and `title` is possible to remove ([#4163](#4163)) ([b6db4a4](b6db4a4))
* **Upload:** removes subtitle displaying file extension ([#4156](#4156)) ([9bf9b9e](9bf9b9e))
* **Upload:** updates drag and drop texts in Norwegian ([#4170](#4170)) ([ad5bbec](ad5bbec))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 10.54.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langz langz langz approved these changes

Assignees
No one assigned
Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tujoworker @langz