-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(Field.String): onBlurValidator error message is displayed instead of the required error message after removing value #4074
Labels
Comments
I re-tested this using the latest version of Eufemia today(v10.53.0), and I still experience the same. |
tujoworker
added a commit
that referenced
this issue
Oct 25, 2024
…#4172) Fixes #4074 With an exception for when `onChange` or `validator` is async. Then we still want to show the `onBlurValidator`. **An example** We have a slow `onChange` event. - The user types. - `onChange` fires and is ongoing while the user types more. - Before `onChange` has finished, the user blurs the field. - The `onBlurValidator` fails. - We show the error coming from the `onBlurValidator`.
tujoworker
pushed a commit
that referenced
this issue
Oct 30, 2024
## [10.54.0](v10.53.0...v10.54.0) (2024-10-30) ### 📝 Documentation * add documentation about `emptyValue` ([#4174](#4174)) ([52457ba](52457ba)), closes [#4070](#4070) ### 🐛 Bug Fixes * **Field.Number:** `decimalLimit={0}` when `currency` should work ([#4167](#4167)) ([68123ea](68123ea)) * **Forms:** correct alignment of Wizard status message (error, warning, info) ([#4185](#4185)) ([a307cda](a307cda)) * **Forms:** ensure autocomplete="off" when autoComplete on Form.Handler is false ([#4184](#4184)) ([6795b9f](6795b9f)) * **Forms:** ensure correct sorting in Field.SelectCountry ([#4196](#4196)) ([8db7720](8db7720)), closes [#4195](#4195) * **Forms:** fix schema validation for required paths with matching name ([#4189](#4189)) ([04caf61](04caf61)), closes [#4179](#4179) * **Forms:** only run onBlurValidator when no other errors are present ([#4172](#4172)) ([d2797f1](d2797f1)), closes [#4074](#4074) * **Forms:** render multiple (combined) Ajv errors with translated messages ([#4176](#4176)) ([2b62ef7](2b62ef7)), closes [#4052](#4052) * **Forms:** updates country names in SelectCountry ([#4187](#4187)) ([bb1b67c](bb1b67c)) * **NumberFormat:** should not throw exception when providing an invalid currency ([#4192](#4192)) ([a0700cd](a0700cd)) * **Table:** fix visible hidden rows for additional expandable table rows ([#4188](#4188)) ([16b6101](16b6101)) ### ✨ Features * add CountryFlag component ([#4181](#4181)) ([76a0c47](76a0c47)) * **Dialog:** add `verticalAlignment` property with `top` alignment support ([#4190](#4190)) ([3ace8b0](3ace8b0)) * **Forms:** add `onDone`, `onCancel` and `onEdit` to Form.Section containers ([#4199](#4199)) ([2f27ad0](2f27ad0)) * **Forms:** add `transformData` to the onSubmit event of Form.Handler ([#4183](#4183)) ([748b604](748b604)) * **Forms:** deprecate `useErrorMessage` hook for when creating your own fields ([#4177](#4177)) ([2ae86f2](2ae86f2)), closes [#4162](#4162) * **Forms:** deprecate Ajv `validationRule` in FormError and deprecate `errorMessages` keys like `pattern` in favor of Eufemia translation keys like `Field.errorPattern` ([#4162](#4162)) ([b50387a](b50387a)) * **Keyboard navigation:** add support for `key` property (useful for fire events like {ArrowDown} during tests) ([#4182](#4182)) ([cc1ffa8](cc1ffa8)) * **Upload:** `text` and `title` is possible to remove ([#4163](#4163)) ([b6db4a4](b6db4a4)) * **Upload:** removes subtitle displaying file extension ([#4156](#4156)) ([9bf9b9e](9bf9b9e)) * **Upload:** updates drag and drop texts in Norwegian ([#4170](#4170)) ([ad5bbec](ad5bbec))
🎉 This issue has been resolved in version 10.54.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🐛 Bug Report
onBlurValidator
error message is displayed instead of the required error message after removing value.I would expect to see the required error message(which I do initially), and not "My Error B".
To Reproduce
https://codesandbox.io/p/sandbox/busy-sunset-lrshrf?workspaceId=9eb653cb-4406-4b8f-bc96-714927cc7fcd
Video of the steps above:
Screen.Recording.2024-10-07.at.12.43.12.mov
The text was updated successfully, but these errors were encountered: