Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Field.Selection): add error styling to button and radio variant #3389

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

joakbjerk
Copy link
Contributor

Before:
Screenshot 2024-03-18 at 09 16 38
Screenshot 2024-03-18 at 09 16 31

After:
Screenshot 2024-03-18 at 09 16 04
Screenshot 2024-03-18 at 09 16 11

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
eufemia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 18, 2024 9:40am

@joakbjerk joakbjerk changed the title fix(Field.Selection): add error styling to radio and ´button´ variant fix(Field.Selection): add error styling to radio and button variant Mar 18, 2024
@joakbjerk joakbjerk changed the title fix(Field.Selection): add error styling to radio and button variant fix(Field.Selection): add error styling to button and radio variant Mar 18, 2024
Copy link

codesandbox-ci bot commented Mar 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@joakbjerk joakbjerk requested a review from tujoworker March 18, 2024 08:51
Copy link
Member

@tujoworker tujoworker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

@joakbjerk joakbjerk merged commit b8093c3 into main Mar 18, 2024
10 checks passed
@joakbjerk joakbjerk deleted the fix/field-selection-error-stylng branch March 18, 2024 12:45
tujoworker pushed a commit that referenced this pull request Mar 19, 2024
## [10.23.0](v10.22.0...v10.23.0) (2024-03-19)

### 📝 Documentation

* **a11y:** add additions related to forms and best practices ([#3385](#3385)) ([416bc21](416bc21))
* **Field.Number:** add info about accessibility regarding step controls ([#3369](#3369)) ([9ee99dd](9ee99dd))
* **forms:** list all sub-components and API in extended features ([#3382](#3382)) ([938bf88](938bf88))
* minor spelling improvements ([#3361](#3361)) ([8ab1a92](8ab1a92))

### 🐛 Bug Fixes

* **Field.Selection:** add error styling to `button` and `radio` variant ([#3389](#3389)) ([b8093c3](b8093c3))
* **PhoneNumber:** fix `must be string` message ([#3362](#3362)) ([c92d061](c92d061))
* **Table:** fix type error when using array of elements ([#3372](#3372)) ([a4d3126](a4d3126))
* **Tag:** delete and backspace key press for removable tag ([#3375](#3375)) ([96e6bbf](96e6bbf))

### ✨ Features

* **Anchor:** Sbanken style based on icon ([#3377](#3377)) ([7cf88a3](7cf88a3))
* **Breadcrumb:** implement new styles and swap out Button with Anchor for the DNB UI ([#3368](#3368)) ([c182230](c182230))
* **Button:** refactor button css ([#3359](#3359)) ([78258c9](78258c9))
* **Card:** add `filled`, `responsive` and `title` props to support a Table and a ScrollView as a child ([#3380](#3380)) ([0a419cc](0a419cc))
* **DatePicker:** Add partial dates ([#3346](#3346)) ([0f6a7d5](0f6a7d5))
* **debounce:** enhance TypeScript support by returning the given function type ([#3379](#3379)) ([d689f09](d689f09))
* **debounce:** return async function if one was given as the input ([#3366](#3366)) ([00cd860](00cd860))
* **Form.SubmitButton:** add submit indicator support ([#3370](#3370)) ([5f3101d](5f3101d))
* **Form.SubmitIndicator:** add indicator for async operations ([#3367](#3367)) ([e32ea40](e32ea40))
* **forms:** implement support for async form submission and autosave feature ([c023c32](c023c32))
* **forms:** implement support for async form submission and autosave feature ([#3378](#3378)) ([5bfbe30](5bfbe30))
* **FormStatus:** remove hover color, so it does not change its color anymore ([#3351](#3351)) ([245f327](245f327))
* **Radio, Checkbox:** enlarge bounding area (clickable/touchable area) ([#3352](#3352)) ([667726b](667726b))
* show error in console when Eufemia CSS and JS versions do not match ([#3371](#3371)) ([a5ef0bd](a5ef0bd))
* **Tag:** add variants clickable, addable and removable (deprecate `onDelete`) ([#3364](#3364)) ([6131139](6131139))
* **useData:** enhance data update and sync logic ([a947ffa](a947ffa))
* **useData:** support data handling without id when nested inside Form.Handler ([#3393](#3393)) ([4eecc5e](4eecc5e))
* **useError:** add support to use it without an id when nested inside Form.Handler ([#3394](#3394)) ([02b95d1](02b95d1))
* **useFieldProps:** add support for data-attributes and replace `ariaAttributes` with `htmlAttributes` ([#3383](#3383)) ([55bb817](55bb817))
* **useFieldProps:** rename useDataValue to useFieldProps ([#3381](#3381)) ([123a543](123a543))
@tujoworker
Copy link
Member

🎉 This PR is included in version 10.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants