feat(Button): refactor button css #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
snorrekim
commented
Mar 1, 2024
•
snorrekim
commented
- Padding is always used on the "outside" of text and icon
- Margin is always used between text and icon
- Css based on button height and icon size is now calculated using variables
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
tujoworker
changed the title
snorrekim
force-pushed
the
feat/button-no-style
branch
from
0f70dfd to
8cc180a
Compare
tujoworker
approved these changes
Mar 5, 2024
...image_snapshots__/globalstatus-for-ui-have-to-match-the-close-button-in-focus-state.snap.png
Show resolved
Hide resolved
snorrekim
force-pushed
the
feat/button-no-style
branch
from
8cc180a to
7385cf0
Compare
tujoworker
pushed a commit
that referenced
this pull request
Mar 19, 2024
## [10.23.0](v10.22.0...v10.23.0) (2024-03-19) ### 📝 Documentation * **a11y:** add additions related to forms and best practices ([#3385](#3385)) ([416bc21](416bc21)) * **Field.Number:** add info about accessibility regarding step controls ([#3369](#3369)) ([9ee99dd](9ee99dd)) * **forms:** list all sub-components and API in extended features ([#3382](#3382)) ([938bf88](938bf88)) * minor spelling improvements ([#3361](#3361)) ([8ab1a92](8ab1a92)) ### 🐛 Bug Fixes * **Field.Selection:** add error styling to `button` and `radio` variant ([#3389](#3389)) ([b8093c3](b8093c3)) * **PhoneNumber:** fix `must be string` message ([#3362](#3362)) ([c92d061](c92d061)) * **Table:** fix type error when using array of elements ([#3372](#3372)) ([a4d3126](a4d3126)) * **Tag:** delete and backspace key press for removable tag ([#3375](#3375)) ([96e6bbf](96e6bbf)) ### ✨ Features * **Anchor:** Sbanken style based on icon ([#3377](#3377)) ([7cf88a3](7cf88a3)) * **Breadcrumb:** implement new styles and swap out Button with Anchor for the DNB UI ([#3368](#3368)) ([c182230](c182230)) * **Button:** refactor button css ([#3359](#3359)) ([78258c9](78258c9)) * **Card:** add `filled`, `responsive` and `title` props to support a Table and a ScrollView as a child ([#3380](#3380)) ([0a419cc](0a419cc)) * **DatePicker:** Add partial dates ([#3346](#3346)) ([0f6a7d5](0f6a7d5)) * **debounce:** enhance TypeScript support by returning the given function type ([#3379](#3379)) ([d689f09](d689f09)) * **debounce:** return async function if one was given as the input ([#3366](#3366)) ([00cd860](00cd860)) * **Form.SubmitButton:** add submit indicator support ([#3370](#3370)) ([5f3101d](5f3101d)) * **Form.SubmitIndicator:** add indicator for async operations ([#3367](#3367)) ([e32ea40](e32ea40)) * **forms:** implement support for async form submission and autosave feature ([c023c32](c023c32)) * **forms:** implement support for async form submission and autosave feature ([#3378](#3378)) ([5bfbe30](5bfbe30)) * **FormStatus:** remove hover color, so it does not change its color anymore ([#3351](#3351)) ([245f327](245f327)) * **Radio, Checkbox:** enlarge bounding area (clickable/touchable area) ([#3352](#3352)) ([667726b](667726b)) * show error in console when Eufemia CSS and JS versions do not match ([#3371](#3371)) ([a5ef0bd](a5ef0bd)) * **Tag:** add variants clickable, addable and removable (deprecate `onDelete`) ([#3364](#3364)) ([6131139](6131139)) * **useData:** enhance data update and sync logic ([a947ffa](a947ffa)) * **useData:** support data handling without id when nested inside Form.Handler ([#3393](#3393)) ([4eecc5e](4eecc5e)) * **useError:** add support to use it without an id when nested inside Form.Handler ([#3394](#3394)) ([02b95d1](02b95d1)) * **useFieldProps:** add support for data-attributes and replace `ariaAttributes` with `htmlAttributes` ([#3383](#3383)) ([55bb817](55bb817)) * **useFieldProps:** rename useDataValue to useFieldProps ([#3381](#3381)) ([123a543](123a543))
|
🎉 This PR is included in version 10.23.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.