chore: add FormRow tests #2106
Merged
chore: add FormRow tests #2106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tujoworker
commented
Mar 16, 2023
•
tujoworker
commented
- To cover the changes in PR fix: remove FormRow context support from components not using FormRow #2103
- This PR is based on PR chore: refactor integration tests to TypeScript #2105
❌ Deploy Preview for eufemia failed.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 871d6cb:
|
tujoworker
force-pushed
the
chore/add-form-row-tests
branch
2 times, most recently
from
3be9f69 to
030de1a
Compare
FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
force-pushed
the
chore/add-form-row-tests
branch
from
030de1a to
871d6cb
Compare
langz
approved these changes
Mar 16, 2023
joakbjerk
pushed a commit
that referenced
this pull request
Mar 27, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
|
🎉 This PR is included in version 10.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
langz
pushed a commit
that referenced
this pull request
May 31, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
added a commit
that referenced
this pull request
May 31, 2023
* chore: convert InputMasked to TypeScript * chore: convert Input to TypeScript * chore(Input): add FormRow and spacing test * chore(InputMasked): add FormRow and spacing test * chore(Radio): add FormRow and spacing test * chore(Swich): add FormRow and spacing test * chore(ToggleButton): add FormRow and spacing test * chore(Checkbox): add FormRow and spacing test * chore(DatePicker): add FormRow and spacing test * chore(Slider): add FormRow test * chore(Textarea): add FormRow and spacing test * chore(FormStatus): add FormRow and spacing test * fix: remove FormRow context support from components not using FormRow FormRow is used for components that have a label. This fix is related with PR #2031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.