fix: remove FormRow context support from components not using FormRow #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for eufemia failed.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5904b8c:
|
tujoworker
force-pushed
the
fix/form-row-attributes
branch
2 times, most recently
from
700f988 to
66457de
Compare
langz
approved these changes
Mar 16, 2023
FormRow is used for components that have a label. This fix is related with PR #2031
tujoworker
force-pushed
the
fix/form-row-attributes
branch
from
66457de to
9e254ba
Compare
tujoworker
force-pushed
the
fix/form-row-attributes
branch
from
124b3fe to
5904b8c
Compare
tujoworker
pushed a commit
that referenced
this pull request
Mar 16, 2023
## [9.47.2](v9.47.1...v9.47.2) (2023-03-16) ### Bug Fixes * **Autocomplete:** pass status props to SubmitButton ([#2004](#2004)) ([fb89114](fb89114)) * **Button:** support rel property ([#1990](#1990)) ([ad029f2](ad029f2)) * remove FormRow context support from components not using FormRow ([#2103](#2103)) ([3a39134](3a39134))
|
🎉 This PR is included in version 9.47.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
tujoworker
pushed a commit
that referenced
this pull request
May 5, 2023
## [10.0.0-beta.3](v10.0.0-beta.2...v10.0.0-beta.3) (2023-05-05) ### ⚠ BREAKING CHANGES * **Anchor:** Anchor was moved form `/elements` to `/components` * **StylisPlugin:** Stylis plugin, `import stylisPlugin from '@dnb/eufemia/style/stylis'`, has been removed. * - The package `dnb-theme-ui` was renamed to `dnb-theme-basis`. - The package `dnb-ui-components` was renamed and moved inside a theme `/style/themes/theme-ui/dnb-theme-components.*`. - `dnb-ui-tags` was renamed and moved form `/style/dnb-ui-tags.*` to `/style/themes/theme-ui/dnb-theme-tags.*`. * SCSS mixin was renamed from `fakeFocus` to `focusRing` as well as `removeFakeFocus` to `removeFocusRing`. * ### 💈 Style Changes * move :root vars into their component itself ([#2102](#2102)) ([7dfc1fb](7dfc1fb)) ### 📝 Documentation * add docs about how to maintain theming ([#2097](#2097)) ([b8f3856](b8f3856)) * add link to new Payment Card Figma file ([#2117](#2117)) ([a841699](a841699)) * add new styles flow diagram ([201611b](201611b)) * adds a dot to quick guide - designers ([#2157](#2157)) ([44f6852](44f6852)) * **Anchor:** fix console warning when using class ([#2125](#2125)) ([e8fcd06](e8fcd06)) * **Autocomplete:** minor spelling improvements ([#2197](#2197)) ([b464ab1](b464ab1)) * **Autocomplete:** refactor jsx examples to tsx ([#2198](#2198)) ([0951682](0951682)) * **Autocomplete:** update docs about the debounce method ([#2138](#2138)) ([119c366](119c366)) * **Best Practices:** adds a dot ([#2151](#2151)) ([629b74f](629b74f)) * **Best Practices:** adds links to children pages ([#2161](#2161)) ([211422e](211422e)) * capitalize component names in descriptions ([#2162](#2162)) ([b96a2f2](b96a2f2)) * **ColorsTable:** fixes color and hover effect ([#2122](#2122)) ([904ba50](904ba50)) * crate main doc for how to deal with brand ([#2100](#2100)) ([0144b5c](0144b5c)) * **CSS Styles:** fix console warning when using class ([#2127](#2127)) ([c1d40b3](c1d40b3)) * **Customization:** adds link to provider/context ([#2160](#2160)) ([2da2eae](2da2eae)) * **DatePicker:** refactor jsx examples to tsx ([#2204](#2204)) ([853cea4](853cea4)) * **Demo Apps:** fix console warning when using class ([#2126](#2126)) ([a800b78](a800b78)) * **DrawerList:** prevents change of direction when scrolling ([#2233](#2233)) ([757cb60](757cb60)) * **DrawerList:** refactor jsx examples to tsx ([#2209](#2209)) ([168cf9a](168cf9a)) * **DrawerList:** renamse fixedPosition to fixed_position ([#2093](#2093)) ([27c3a2d](27c3a2d)) * **Font Weights:** fix console warning when using class ([#2132](#2132)) ([63f3c1d](63f3c1d)) * **FormLabel:** improve description of vertical prop ([#2098](#2098)) ([7f0caee](7f0caee)) * **FormRow:** refactor jsx examples to tsx ([#2219](#2219)) ([06b5406](06b5406)) * **FormSet:** refactor jsx examples to tsx ([#2208](#2208)) ([76d2c30](76d2c30)) * **Fragments:** minor docs improvement ([#2232](#2232)) ([80a964c](80a964c)) * **Front Page:** minor text improvements ([#2139](#2139)) ([34863b9](34863b9)) * **GlobalStatus:** refactor jsx examples to tsx ([#2202](#2202)) ([71bca1c](71bca1c)) * **Heading:** refactor jsx examples to tsx ([#2205](#2205)) ([44e2a39](44e2a39)) * **Helpers:** Adds info about dnb-unstyled-list in info page ([#2171](#2171)) ([da81526](da81526)) * **HTML Elements:** move mdx of unstyled and unsupported to elements.mdx ([#2154](#2154)) ([90d5a3a](90d5a3a)) * **Icon Details:** fix console warning when using class ([#2128](#2128)) ([3698816](3698816)) * **Icons:** link to v10 docs ([#2182](#2182)) ([7eaf2d1](7eaf2d1)) * **InputMasked:** refactor jsx examples to tsx ([#2207](#2207)) ([ffb5ad0](ffb5ad0)) * **Logos:** fix console warning in console ([#2123](#2123)) ([979e8d0](979e8d0)) * **Modal:** refactor jsx examples to tsx ([#2218](#2218)) ([278b24b](278b24b)) * **Naming conventions:** fix console warning when using class ([#2129](#2129)) ([da19575](da19575)) * remove docs about CSS vars polyfills ([#2145](#2145)) ([766968e](766968e)) * remove docs about importing from @dnb/eufemia/elements ([#2173](#2173)) ([21678c3](21678c3)) * **ScrollView:** controll -> control ([#2225](#2225)) ([31fff2c](31fff2c)) * **ScrollView:** refactor jsx examples to tsx ([#2210](#2210)) ([5787b12](5787b12)) * **ScrollView:** sets Description as header in docs ([#2168](#2168)) ([d998f4f](d998f4f)) * **Skeleton:** refactor jsx examples to tsx ([#2203](#2203)) ([2bfbaef](2bfbaef)) * **SkipContent:** refactor jsx examples to tsx ([#2211](#2211)) ([1f9e2f4](1f9e2f4)) * **Space:** refactor jsx examples to tsx ([#2199](#2199)) ([d369ab5](d369ab5)) * **Space:** refactor jsx properties to tsx ([#2216](#2216)) ([bc88149](bc88149)) * **Table:** refactor jsx examples to tsx ([#2206](#2206)) ([97bb44d](97bb44d)) * **Timeline:** fix broken link to example ([#2241](#2241)) ([202e7eb](202e7eb)) * **ToggleButton:** removes outdated label_position docs ([#2141](#2141)) ([c3f168b](c3f168b)) * **TypeScript:** remove outdated docs ([#2124](#2124)) ([0f9f62f](0f9f62f)) * **Typography:** fix console warning when using class ([#2133](#2133)) ([5551d92](5551d92)) * **Typography:** hast -> has ([#2221](#2221)) ([de710b2](de710b2)) ### 🐛 Bug Fixes * **Button:** align large icon size to be same as in Figma ([#2239](#2239)) ([2f9a287](2f9a287)) * **Button:** support for FormRow and FormSet ([#2147](#2147)) ([59f0a22](59f0a22)) * **DatePicker:** fix text prop for submit and cancel buttons ([#2254](#2254)) ([8633cd1](8633cd1)) * **Datepicker:** reset and cancel button gap ([f3d0579](f3d0579)) * **DatePicker:** shortcut buttons ([#2266](#2266)) ([5b95305](5b95305)) * **InputMasked:** on custom mask – avoid interaction stall after focus ([#2269](#2269)) ([02caccb](02caccb)) * **NumberFormat:** hide screen reader only text from being copied as HTML ([#2240](#2240)) ([f8fe6c3](f8fe6c3)) * remove FormRow context support from components not using FormRow ([#2103](#2103)) ([3a39134](3a39134)) * **ToggleButton:** fixes error when pressing enter ([#2183](#2183)) ([37b2e45](37b2e45)) ### ✨ Features * add shared Theme component and useTheme hook ([#2112](#2112)) ([10a5f5e](10a5f5e)) * **Anchor:** create styles for Sbanken ([#2250](#2250)) ([330f97e](330f97e)) * **Anchor:** move from elements to components ([#2275](#2275)) ([c6261cd](c6261cd)) * **Icons:** add new icons `handshake`, `heavy_equipment`, `id_card`, `investment_account`, `keyfigures`, `portfolio_analytics`, `sea_transport`, `shield_lock`, `file_zip`, `bus`, `building_shopping`, `handshake`, `heavy_equipment` ([#2178](#2178)) ([80d4b9d](80d4b9d)) * **Icons:** move all icons assets to `dnb` subfolder: assets/icons/dnb/*.svg ([#2187](#2187)) ([5513ca8](5513ca8)) * **Icons:** remove iOS (PDF) icons library support ([#2170](#2170)) ([c238f6d](c238f6d)) * **Logo:** Add brand and variant params for Sbanken logo ([#2271](#2271)) ([e850b25](e850b25)) * move `dnb-ui-tags` to themes ([#2140](#2140)) ([0da5214](0da5214)) * move browser assets to dnb subfolder ([#2083](#2083)) ([005c123](005c123)) * move DNB icons to subfolder (with v9 compatibility) ([#2200](#2200)) ([94381b4](94381b4)) * move dnb image assets to own subfolder ([#2099](#2099)) ([213f6c2](213f6c2)) * **PaymentCard:** new card designs & new products ([#2264](#2264)) ([c7f9c67](c7f9c67)) * **PaymentCard:** rename type Metalic to Metallic ([#2226](#2226)) ([cc4498b](cc4498b)) * rename SCSS mixin `fakeFocus` to `focusRing` ([#2110](#2110)) ([8c27aeb](8c27aeb)) * simplify CSS packages/themes structure ([f44fc0b](f44fc0b)) * **Skeleton:** removes style_type prop ([#2095](#2095)) ([c7cdadb](c7cdadb)) * **StylisPlugin:** removes stylis plugin ([#2156](#2156)) ([fa42b39](fa42b39)) * **Theming:** add `VisibilityByTheme` as a shared component ([#2280](#2280)) ([49b3f9a](49b3f9a)) * **Typography:** add `--line-height-lead` property ([#2237](#2237)) ([bbd49ce](bbd49ce)) * **Typography:** remove small prop from paragraph (p) ([#2234](#2234)) ([b8cf2de](b8cf2de)) * use CSS vars in focus-ring (`fakeFocus`) ([#2109](#2109)) ([21defb5](21defb5))
|
🎉 This PR is included in version 10.0.0-beta.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
langz
added a commit
that referenced
this pull request
May 31, 2023
langz
added a commit
that referenced
this pull request
May 31, 2023
langz
added a commit
that referenced
this pull request
May 31, 2023
…03-changes-in-v10 chore: manually include #2103 in v10
tujoworker
pushed a commit
that referenced
this pull request
May 31, 2023
tujoworker
pushed a commit
that referenced
this pull request
May 31, 2023
tujoworker
pushed a commit
that referenced
this pull request
May 31, 2023
tujoworker
pushed a commit
that referenced
this pull request
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FormRow is only used for components that have a label. We have docs about it.