fix(Slider): use numbers instead of css reverse when reversing slider #1532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tujoworker
force-pushed
the
fix/slider-reverse
branch
from
2a63269 to
d852ac0
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fb30c0f:
|
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18m PerformanceLighthouse report
|
tujoworker
force-pushed
the
fix/slider-reverse
branch
from
d852ac0 to
ca346be
Compare
tujoworker
force-pushed
the
fix/slider-reverse
branch
from
ca346be to
fb30c0f
Compare
tujoworker
pushed a commit
that referenced
this pull request
Aug 29, 2022
# [9.30.0](v9.29.0...v9.30.0) (2022-08-29) ### Bug Fixes * **Slider:** fix reverse with min and max defiend ([#1533](#1533)) ([6c169b4](6c169b4)) * **Slider:** prevent onChange being called with same value ([#1528](#1528)) ([115b056](115b056)) * **Slider:** use numbers instead of css reverse when reversing slider ([#1532](#1532)) ([e2e83a0](e2e83a0)) * **Theme:** correct DNB Eiendom state colors mint-green-50 to pistachio ([#1527](#1527)) ([b7f532e](b7f532e)) * **withCamelCaseProps:** make exception for className ([#1534](#1534)) ([a0a0082](a0a0082)) ### Features * **Slider:** add multiThumbBehavior property ([#1526](#1526)) ([f835651](f835651))
|
🎉 This PR is included in version 9.30.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to spam with yet another Slider PR.
This time, we remove the CSS reverse usage, because, if we want a Tooltip inlined, it gets reversed too. So now we only used numbers to reverse the behavior. Also to note, if
verticalis true, we use actually reverse internally. So its not only for thereverseproperty.Here is a CSB and a demo to test out.