Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): prevent onChange being called with same value #1528

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

tujoworker
Copy link
Member

@tujoworker tujoworker commented Aug 25, 2022

To verify this, a test both for single number and multi numbers is added.

@tujoworker tujoworker requested a review from langz August 25, 2022 10:08
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 043f1c5:

Sandbox Source
eufemia-starter Configuration

@gatsby-cloud
Copy link

gatsby-cloud bot commented Aug 25, 2022

Gatsby Cloud Build Report

DNB Eufemia Portal

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12m

Performance

Lighthouse report

Metric Score
Performance 🔶 66
Accessibility 💚 100
Best Practices 💚 92
SEO 💚 92

🔗 View full report

@tujoworker tujoworker merged commit 115b056 into main Aug 25, 2022
@tujoworker tujoworker deleted the fix/slider-on-change-emit branch August 25, 2022 10:54
tujoworker pushed a commit that referenced this pull request Aug 29, 2022
# [9.30.0](v9.29.0...v9.30.0) (2022-08-29)

### Bug Fixes

* **Slider:** fix reverse with min and max defiend ([#1533](#1533)) ([6c169b4](6c169b4))
* **Slider:** prevent onChange being called with same value ([#1528](#1528)) ([115b056](115b056))
* **Slider:** use numbers instead of css reverse when reversing slider ([#1532](#1532)) ([e2e83a0](e2e83a0))
* **Theme:** correct DNB Eiendom state colors mint-green-50 to pistachio ([#1527](#1527)) ([b7f532e](b7f532e))
* **withCamelCaseProps:** make exception for className ([#1534](#1534)) ([a0a0082](a0a0082))

### Features

* **Slider:** add multiThumbBehavior property ([#1526](#1526)) ([f835651](f835651))
@tujoworker
Copy link
Member Author

🎉 This PR is included in version 9.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants