-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace CRABCache use with CERN S3 #4971
Comments
code that refers to crabcache in |
Need to take care also of CRABClient/src/python/CRABClient/Commands/submit.py Lines 376 to 383 in 5951982
|
@ddaina I have started to work on this since I need at least to submit a task using S3 as cache to check what exactly goes in the DB and make progress on crabserver side. But I found that it is more work than initially thought since we need to pass a RESTServer object to the tarball handling code in CRABClient/src/python/CRABClient/JobType/UserTarball.py Lines 156 to 159 in 5951982
The code I pointed to at the top of this issue is only about uploading log files :-( So I decided to simplify a bit the way we handle the RESTServer communications now introducing a dictionary to track together the HTTPRequest object and the instance name:
this requires a change in almost all commands, as done earlier in It is easier if I take care of this myself. I will leave the log upload part to you though. |
log upload still to be dealt with heavy changes everywhere will need extensive validation
@ddaina I am fixing last pylint complains then will merge #4983 which , coupled with latest, unmerged yet, changes to the two files imported from CRABServer, manages to submit using S3 as crabcache. Of course submitted task does not work, because TW does not know how to use S3 yet. I will work on that, in the meanwhile you can, in whichever order:
Remember: If you have time for strategical thinking, we could talk about how to plan for a smooth transistion, which may mean changing what I just did, but the sooner the better, before we end up like for new Publisher in a years-long mess. |
most work will have to be done in the server.
CRABClient will have to replace the current uplaod to cache with two calls:
all work of tracking object ids, checking used space, etc, will be done in CRABServer
Code to be changed is in here
CRABClient/src/python/CRABClient/ClientUtilities.py
Lines 232 to 259 in 5951982
The text was updated successfully, but these errors were encountered: