Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document all places where CRABCache is used #6400

Closed
belforte opened this issue Feb 11, 2021 · 5 comments
Closed

document all places where CRABCache is used #6400

belforte opened this issue Feb 11, 2021 · 5 comments
Assignees

Comments

@belforte
Copy link
Member

document all places where CRABCache is used and describe the needed functionality

i.e. look for all places where there are references to
https://github.com/dmwm/CRABServer/tree/master/src/python/UserFileCache

@ddaina
Copy link
Contributor

ddaina commented Feb 23, 2021

@belforte I had first look into this task and tried to list files that uses UserFileCache. I documented it in excel, once we get through review cycle and come to the final result, I will copy it here for documentation purpose.

For now, you can find file here.

@belforte
Copy link
Member Author

thanks, looks good. See also dmwm/CRABClient#4971

@belforte
Copy link
Member Author

belforte commented Mar 15, 2021

I am turning that spreadsheet into a list items below. I have also updated the spreadsheet with comments as appropriate.

Will mark tasks below as closed once they have their own GH issues so we close this as "done with making the list".

@ddaina please cross check that I did not forget something, thanks

@ddaina
Copy link
Contributor

ddaina commented Mar 15, 2021

verify if there is references to crabcache in old, unused CRAB Client test file https://github.com/dmwm/CRABClient/blob/master/test/python/CRABClient_t/JobType_t/CMSSW_t.py and remove it

indeed, crabcache is not used there. we can mark it is done.

Also, I cannot find in this list issue that would cover this use case: https://github.com/dmwm/CRABServer/blob/master/src/python/TaskWorker/Actions/DagmanCreator.py#L1157-#L1174

@belforte
Copy link
Member Author

well spotted. I added a note [here]9#6457 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants