Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename num_output_group -> num_class, random_forest_flag -> average_tree_output (part of #229) #233

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Dec 7, 2020

Extracted from #229 for easier reviewing.

@hcho3 hcho3 changed the title Rename num_output_group -> num_class, random_forest_flag -> average_tree_output Rename num_output_group -> num_class, random_forest_flag -> average_tree_output (part of #229) Dec 7, 2020
@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #233 (d50fdf6) into mainline (a4fa0a2) will decrease coverage by 0.05%.
The diff coverage is 95.38%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #233      +/-   ##
==============================================
- Coverage       83.79%   83.73%   -0.06%     
  Complexity         44       44              
==============================================
  Files              93       93              
  Lines            6780     6855      +75     
  Branches           42       42              
==============================================
+ Hits             5681     5740      +59     
- Misses           1075     1091      +16     
  Partials           24       24              
Impacted Files Coverage Δ Complexity Δ
include/treelite/frontend.h 90.00% <ø> (ø) 0.00 <0.00> (ø)
include/treelite/tree.h 93.02% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/gbm_classifier.py 93.75% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/gbm_multi_classifier.py 94.11% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/gbm_regressor.py 93.75% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/rf_classifier.py 100.00% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/rf_multi_classifier.py 100.00% <ø> (ø) 0.00 <0.00> (ø)
python/treelite/sklearn/rf_regressor.py 100.00% <ø> (ø) 0.00 <0.00> (ø)
...main/java/ml/dmlc/treelite4j/java/TreeliteJNI.java 45.45% <ø> (ø) 2.00 <0.00> (ø)
src/compiler/ast/builder.h 100.00% <ø> (ø) 0.00 <0.00> (ø)
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4fa0a2...d50fdf6. Read the comment docs.

@hcho3 hcho3 merged commit 910d6f7 into dmlc:mainline Dec 8, 2020
@hcho3 hcho3 deleted the new_model_spec2 branch December 8, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants