Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New model specification #229

Merged
merged 5 commits into from
Dec 10, 2020
Merged

New model specification #229

merged 5 commits into from
Dec 10, 2020

Conversation

hcho3
Copy link
Collaborator

@hcho3 hcho3 commented Dec 4, 2020

Implement #228

Closes #133
Closes #228

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #229 (f1a513a) into mainline (910d6f7) will increase coverage by 0.12%.
The diff coverage is 91.57%.

Impacted file tree graph

@@              Coverage Diff               @@
##             mainline     #229      +/-   ##
==============================================
+ Coverage       83.40%   83.52%   +0.12%     
  Complexity         44       44              
==============================================
  Files              93       93              
  Lines            6814     6873      +59     
  Branches           42       42              
==============================================
+ Hits             5683     5741      +58     
- Misses           1107     1108       +1     
  Partials           24       24              
Impacted Files Coverage Δ Complexity Δ
include/treelite/tree.h 93.02% <ø> (ø) 0.00 <0.00> (ø)
src/compiler/ast/builder.h 100.00% <ø> (ø) 0.00 <0.00> (ø)
src/compiler/failsafe.cc 89.00% <40.00%> (-0.80%) 0.00 <0.00> (ø)
include/treelite/tree_impl.h 89.67% <85.71%> (-0.22%) 0.00 <0.00> (ø)
src/compiler/ast_native.cc 91.40% <91.42%> (-0.29%) 0.00 <0.00> (ø)
src/compiler/ast/build.cc 96.49% <100.00%> (ø) 0.00 <0.00> (ø)
src/frontend/builder.cc 77.99% <100.00%> (+1.37%) 0.00 <0.00> (ø)
src/frontend/lightgbm.cc 84.57% <100.00%> (+0.55%) 0.00 <0.00> (ø)
src/frontend/xgboost.cc 79.70% <100.00%> (+0.94%) 0.00 <0.00> (ø)
src/frontend/xgboost_json.cc 76.00% <100.00%> (+0.79%) 0.00 <0.00> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910d6f7...d5e4f3e. Read the comment docs.

@hcho3 hcho3 changed the title [WIP] New model specification New model specification Dec 5, 2020
@hcho3 hcho3 marked this pull request as ready for review December 5, 2020 03:45
include/treelite/tree.h Outdated Show resolved Hide resolved
include/treelite/tree.h Show resolved Hide resolved
@hcho3 hcho3 merged commit d2480c0 into dmlc:mainline Dec 10, 2020
@hcho3 hcho3 deleted the new_model_spec branch December 10, 2020 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] New model specification LightGBM RF classifier with num_class > 2 is currently not supported
3 participants