Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Organize cmake file (Fixed) #7715

Merged
merged 10 commits into from
Aug 18, 2024
Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 17, 2024

Description

The regression issue in #7657 was caused by not enabling OpenMP for GraphBolt.

This PR is the same as #7657 except that it enables OpenMP for GraphBolt and remove unused options from build.sh.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin marked this pull request as draft August 17, 2024 02:36
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 17, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 17, 2024

Commit ID: 7a219f4

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin marked this pull request as ready for review August 17, 2024 03:34
CMakeLists.txt Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 17, 2024

Commit ID: debe474

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 17, 2024

Commit ID: e647c60

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title [Build][2] Organize cmake file [Build] Organize cmake file (Fixed) Aug 17, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 17, 2024

Commit ID: 4374589

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit b1e3943 into dmlc:master Aug 18, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_build_type_release branch August 18, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants