Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Organize cmake file. #7657

Merged
merged 6 commits into from
Aug 6, 2024
Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Aug 5, 2024

Description

The options were being globally set and were even being passed to other libraries. This PR aims to refine that a little and pass only the options that makes sense to pass around.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 78daf23

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

graphbolt/build.sh Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: c64c3bc

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from frozenbugs August 5, 2024 18:15
@mfbalin mfbalin changed the title [GraphBolt] Set build type to Release. [GraphBolt] Cleanup cmake file. Aug 5, 2024
@mfbalin mfbalin changed the title [GraphBolt] Cleanup cmake file. [GraphBolt] Organize cmake file. Aug 5, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: a9f99a8

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 3097f3f

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: 3cce758

Build ID: 5

Status: ❌ CI test failed in Stage [CPU Build (Win64)].

Report path: link

Full logs path: link

@mfbalin mfbalin changed the title [GraphBolt] Organize cmake file. [Build] Organize cmake file. Aug 5, 2024
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 5, 2024

Commit ID: cde249d

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit 4032c2a into dmlc:master Aug 6, 2024
2 checks passed
@mfbalin mfbalin deleted the gb_build_type_release branch August 6, 2024 12:48
frozenbugs added a commit that referenced this pull request Aug 16, 2024
@mfbalin mfbalin restored the gb_build_type_release branch August 17, 2024 02:29
@mfbalin mfbalin mentioned this pull request Aug 17, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants