Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base/build: using Libdl.dlext for searching lib #265

Merged
merged 1 commit into from
Sep 10, 2017
Merged

base/build: using Libdl.dlext for searching lib #265

merged 1 commit into from
Sep 10, 2017

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Sep 1, 2017 •
edited
Loading

Blocker: #271

@iblislin
Copy link
Member Author

iblislin commented Sep 1, 2017

travis ci failure looks weird

g++: internal compiler error: Killed (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <file:///usr/share/doc/gcc-4.8/README.Bugs> for instructions.
make: *** [build/src/operator/tensor/broadcast_reduce_op_index.o] Error 4
make: *** Waiting for unfinished jobs....
================================[ ERROR: MXNet ]================================
LoadError: failed process: Process(`make -j8 USE_BLAS=openblas 'MSHADOW_LDFLAGS=-lm /home/travis/julia/bin/../lib/julia/libopenblas64_.so'`, ProcessExited(2)) [2]
while loading /home/travis/.julia/v0.6/MXNet/deps/build.jl, in expression starting on line 58
================================================================================

vchuravy
vchuravy previously requested changes Sep 1, 2017
View reviewed changes
deps/build.jl
@@ -11,7 +11,8 @@ curr_win = "20170502"
if haskey(ENV, "MXNET_HOME")
info("MXNET_HOME environment detected: $(ENV["MXNET_HOME"])")
info("Trying to load existing libmxnet...")
lib = Libdl.find_library(["libmxnet", "libmxnet.so"], ["$(ENV["MXNET_HOME"])/lib"])
lib = Libdl.find_library("libmxnet.$(Libdl.dlext)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe under linux you need to continue to use "libmxnet" without the Libdl.ext

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems both work.
I can add it back if you want it.

% uname -a
Linux kaladbolg 4.12.8-2-ARCH #1 SMP PREEMPT Fri Aug 18 14:08:02 UTC 2017 x86_64 GNU/Linux
% ls
libmxnet.so*  libmxnet-test.so*

julia> p = Libdl.find_library(["libmxnet-test.so"], [pwd()])        
"/home/iblis/.julia/v0.5/MXNet/deps/usr/lib/libmxnet-test.so"       

julia> Libdl.dlopen_e(p)          
Ptr{Void} @0x0000000002f4c7b0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Then we need to figure out why Travis is failing.

@iblislin
Copy link
Member Author

iblislin commented Sep 6, 2017

Travis kill the julia 0.6 build, due to no output in 10 mins:
https://travis-ci.org/dmlc/MXNet.jl/jobs/272416995

But I think the stdout of make blablabla (from Pkg.build) is gone in julia 0.6 and master.
please checkout
* https://github.com/JuliaLang/julia/blame/f32499fa7ef8c29049a39344565011b10401b23b/base/pkg/entry.jl#L618
* JuliaLang/julia#20070 (review)

@iblislin iblislin mentioned this pull request Sep 6, 2017
Merged
@iblislin iblislin force-pushed the ext branch 3 times, most recently from 6ee3ba9 to e9d18b1 Compare September 6, 2017 15:28
@vchuravy vchuravy self-requested a review September 6, 2017 15:37
@vchuravy vchuravy dismissed their stale review September 6, 2017 15:38

No longer relevant

@iblislin iblislin force-pushed the ext branch 3 times, most recently from bde9490 to 4c423df Compare September 7, 2017 15:07
@iblislin
Copy link
Member Author

iblislin commented Sep 7, 2017

I think travis's build hit another issue:
apache/mxnet#7741 (comment)

@iblislin
Copy link
Member Author

iblislin commented Sep 8, 2017

I will rebase this PR if this issue gets resolved: #267

@vchuravy
Copy link
Collaborator

vchuravy commented Sep 9, 2017

Can we split the travis related commits into their own pr?

@iblislin
Copy link
Member Author

iblislin commented Sep 9, 2017

sure. It's #271

@iblislin iblislin changed the title base: using Libdl.dlext for searching lib base/build: using Libdl.dlext for searching lib Sep 9, 2017
@vchuravy vchuravy merged commit b68ce5b into dmlc:master Sep 10, 2017
@vchuravy vchuravy removed their request for review September 10, 2017 16:51
@iblislin iblislin deleted the ext branch September 10, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iblislin @vchuravy