Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cblas: import all func prototype into header #267

Closed
wants to merge 4 commits into from

Conversation

iblislin
Copy link
Member

@iblislin iblislin commented Sep 8, 2017

according to this PR in MXNet: apache/mxnet#7741

@iblislin
Copy link
Member Author

iblislin commented Sep 8, 2017

@iblislin iblislin changed the title cblas: add func prototype for cblas_(s|d)syrk WIP: cblas: import all func prototype into header Sep 8, 2017
@iblislin
Copy link
Member Author

iblislin commented Sep 8, 2017

Edit: please ignore this comment
please checkout the current cblas.h:

└─[iblis@kaladbolg]% clang -E cblas.h | tail                                                                           
       const blasint clda, const blasint cldb);                                                                        
                                                                                                                       
void cblas_sgeadd(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const float calpha, float *a,
 const blasint clda, const float cbeta,
    float *c, const blasint cldc);                                                                                     
void cblas_dgeadd(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const double calpha, double *
a, const blasint clda, const double cbeta,                 
    double *c, const blasint cldc);                                                                                    
void cblas_cgeadd(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const float *calpha, float *a
, const blasint clda, const float *cbeta,                  
    float *c, const blasint cldc);                                                                                     
void cblas_zgeadd(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const double *calpha, double
*a, const blasint clda, const double *cbeta,               
    double *c, const blasint cldc);
┌─[~/git/MXNet/deps]                                       
| [Venv(py36)] [ cblas] [-- INSERT --]                    
└─[iblis@kaladbolg]% clang -DINTERFACE64 -E cblas.h | tail
       const blasint clda, const blasint cldb);            
                             
void cblas_sgeadd64_(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const float calpha, float
*a, const blasint clda, const float cbeta,
    float *c, const blasint cldc);
void cblas_dgeadd64_(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const double calpha, doubl
e *a, const blasint clda, const double cbeta,
    double *c, const blasint cldc);
void cblas_cgeadd64_(const enum CBLAS_ORDER CORDER,const blasint crows, const blasint ccols, const float *calpha, float
 *a, const blasint clda, const float *cbeta,
    float *c, const blasint cldc);
...

Also, enable ILP64 symbol if INTERFACE64 defined
@iblislin iblislin changed the title WIP: cblas: import all func prototype into header cblas: import all func prototype into header Sep 9, 2017
@iblislin
Copy link
Member Author

iblislin commented Sep 9, 2017

ready for review, please squash it while merging

@vchuravy
Copy link
Collaborator

vchuravy commented Sep 9, 2017

Manually merged as 873715b, thank you for your work!

@vchuravy vchuravy closed this Sep 9, 2017
@iblislin iblislin deleted the cblas branch September 9, 2017 17:05
@iblislin iblislin mentioned this pull request Mar 24, 2018
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants