Add WSL support via UnixSocket

[mehrdadn]

Handles dlech/KeeAgent#220.

Note: Please perform a security review before using this code. I only made these changes for my own personal use, so I may have paid insufficient attention to certain things (like file/socket permissions).

[dlech]

Nice! I assume that this is for WSL1 and not WLS2? If so, it would be nice to update the names to reflect that.

[mehrdadn]

Thanks for the review! Unfortunately all of them appear to be regarding the existing coding patterns, not anything done differently in my PR. So you might want to take care of them alongside the others when you get the chance.

[dlech]

Did you also see the question about WSL1 vs WSL2?

[mehrdadn]

Oh sorry, I forgot to reply to that. I guess it depends how you look at it. To my knowledge WSL2 doesn't support AF_UNIX interop at all currently so I don't expect this would help on WSL2. But I also don't expect a Socket or Agent for WSL2 would look any different than this one—that would imply Microsoft would introduce a new AF_UNIXv2 or something which would be bizarre for no gain that I can envision. So I thought just calling it WSL would seem apt, but if you think it's better to call it WSL1 I guess I can do that too.

[dlech]

How about just adding a comment at the top of the file saying that it only works for WSL1?

[mehrdadn]

Ok sure!

[mehrdadn]

Just pushed the changes.

[codecov-commenter]

Codecov Report

Merging #14 (7c85e3a) into master (ae6f8b9) will increase coverage by 0.50%.
The diff coverage is 64.17%.

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   52.02%   52.53%   +0.50%     
==========================================
  Files          40       43       +3     
  Lines        4755     4955     +200     
  Branches      458      481      +23     
==========================================
+ Hits         2474     2603     +129     
- Misses       2120     2182      +62     
- Partials      161      170       +9     

Impacted Files	Coverage Δ
SshAgentLib/PageantAgent.cs	0.00% <0.00%> (ø)
SshAgentLib/Microsoft/UnixDomainSocketEndPoint.cs	53.93% <53.93%> (ø)
SshAgentLib/WslSocket.cs	88.50% <88.50%> (ø)
...tLib/Microsoft/UnixDomainSocketEndPoint.Windows.cs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6f8b9...7c85e3a. Read the comment docs.

[mehrdadn]

@dlech Were you intending to merge this?

[dlech]

I will test it tomorrow.

[mehrdadn]

Ah awesome, thanks!

[dlech]

I reworked this a bit to simplify the code and fix some issues.