Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows/WSL Interop with AF_UNIX #220

Closed
drujd opened this issue Apr 3, 2018 · 9 comments
Closed

Support Windows/WSL Interop with AF_UNIX #220

drujd opened this issue Apr 3, 2018 · 9 comments

Comments

@drujd
Copy link

drujd commented Apr 3, 2018

https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/
https://blogs.msdn.microsoft.com/commandline/2018/02/07/windowswsl-interop-with-af_unix/

Hello, it would be nice to support (besides Cygwin and msysGit sockets) native AF_UNIX sockets that come with Windows 1803. That way, ssh/KeeAgent interop in WSL should work just by setting SSH_AUTH_SOCK.

That way, in WSL, we wouldn't have to use (possibly unsecure) workarounds such as https://gist.github.com/strarsis/e533f4bca5ae158481bbe53185848d49 or https://github.com/vuori/weasel-pageant .

@filviu
Copy link

filviu commented Jun 4, 2020

Right now I'm using vuori/weasel-pageant which is abandoned (it uses WSL-Win32 interop used before 1803) and looking to switch to benpye/wsl-ssh-pageant which does offer AF_UNIX but it still means I have to run one more agent just for WSL.

It'd sure be nice to be able to switch to a native solution.

@BobVul
Copy link

BobVul commented Aug 2, 2020

I ended up creating a set of wrapper scripts (https://github.com/BobVul/ssh-pageant-scripts) for benpye/wsl-ssh-pageant. They launch the bridging agent on demand and tied to the lifecycle of the launched application. This at least lets me avoid starting another agent separately/keeping it running forever in the background.

@mehrdadn
Copy link

I've implemented this for myself currently. Is this project still being maintained as of 2021? And if so, what is the process/policy on contributing code?

@dlech
Copy link
Owner

dlech commented Jul 22, 2021

Still maintained - just very low priority for me right now. Changes with automated tests are more likely to be accepted.

@mehrdadn
Copy link

Ah I see, I don't have tests or such unfortunately. Was just wondering if I could leave some code here semi-anonymously and have someone handle the rest. I guess if anyone becomes interested in that feel free to ping me. Thanks!

@dlech
Copy link
Owner

dlech commented Jul 22, 2021

Feel free to make a PR even if it is incomplete.

@mehrdadn
Copy link

Done!

@mehrdadn
Copy link

I'm guessing you can close this issue now that those are merged. 🙂

@dlech
Copy link
Owner

dlech commented Jan 29, 2022

This was merged in #321.

@dlech dlech closed this as completed Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants