Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: review and edits of PR #2510 docs: manage workspaces with kubectl #14

Merged
merged 6 commits into from
Jan 23, 2023

Conversation

max-cx
Copy link

@max-cx max-cx commented Jan 19, 2023

What does this pull request change?

Review and edit eclipse-che#2510

What issues does this pull request fix or reference?

https://issues.redhat.com/browse/RHDEVDOCS-3216
https://issues.redhat.com/browse/RHDEVDOCS-4093

Specify the version of the product this pull request applies to

See eclipse-che#2510

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

⚡️ Deploying pull request preview...

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

Click here to review and test in web IDE: Contribute

Copy link
Owner

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just have a couple of suggestions

@dkwon17 dkwon17 merged commit 3ba4526 into dkwon17:apiissues Jan 23, 2023
@max-cx max-cx deleted the apiissues branch January 24, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants